jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/371979 )
Change subject: Use jQuery for restoring the shuffled question numbers
......................................................................
Use jQuery for restoring the shuffled question numbers
Use jQuery instead of JavaScript DOM methods for restoring the question
numbers' shuffled order after shuffling the questions. Use docstring
for documentation instead of a plain comment.
Change-Id: I053ad287293f1627c3a58ad13b126f2bdd42b576
---
M modules/ext.quiz.js
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Fomafix: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.quiz.js b/modules/ext.quiz.js
index bb98f78..b0fa697 100644
--- a/modules/ext.quiz.js
+++ b/modules/ext.quiz.js
@@ -72,13 +72,15 @@
}
}
- // Reassign numbering to shuffled questions
+ /**
+ * Reassign numbering to shuffled questions
+ *
+ * @param {jQuery} $area The shuffled quiz area.
+ */
function shuffleNumbering( $area ) {
- $area = $area[0];
- var list = $area.getElementsByClassName( 'questionId' );
- for( var i =0; i < list.length ; ++i ) {
- list[i].innerHTML = i+1;
- }
+ $area.find( '.questionId' ).each( function ( i ) {
+ $( this ).text( i+1 );
+ } );
}
/** Prepare the quiz for "javascriptable" browsers
--
To view, visit https://gerrit.wikimedia.org/r/371979
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I053ad287293f1627c3a58ad13b126f2bdd42b576
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Quiz
Gerrit-Branch: master
Gerrit-Owner: Tacsipacsi <[email protected]>
Gerrit-Reviewer: Fomafix <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
