Petar.petkovic has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399440 )
Change subject: Fix old style filters disappearing regression
......................................................................
Fix old style filters disappearing regression
Add FormWrapperWidget after controller is initialized, to avoid it
being removed when changes list view model is updated during
initialization.
Change-Id: I3bd4d1bc9efbcdbf99493498267ed1a690fd1ab2
---
M resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MainWrapperWidget.js
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/40/399440/1
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
b/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
index f770899..fe8bcf4 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
@@ -100,6 +100,8 @@
conditionalViews
);
+ mainWrapperWidget.initFormWidget( specialPage );
+
$( 'a.mw-helplink' ).attr(
'href',
'https://www.mediawiki.org/wiki/Special:MyLanguage/Help:New_filters_for_edit_review'
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MainWrapperWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MainWrapperWidget.js
index e64ffd8..8002045 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MainWrapperWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MainWrapperWidget.js
@@ -61,7 +61,6 @@
$( 'body' )
.append( this.$overlay )
.addClass( 'mw-rcfilters-ui-initialized' );
- this.initFormWidget();
};
/* Initialization */
--
To view, visit https://gerrit.wikimedia.org/r/399440
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bd4d1bc9efbcdbf99493498267ed1a690fd1ab2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
