Sharvaniharan has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399541 )
Change subject: [WIP] Unit tests for reading lists
......................................................................
[WIP] Unit tests for reading lists
- Created instrumented tests for dbHelper
- Tests created for code test coverage
todo: higher level tests for testing functionality w.r.t the app logic
Bug: T183169
Change-Id: I75307babfe4914ac6bbe840963d0fca94dcf13f6
---
A
app/src/androidTest/java/org/wikipedia/readinglist/database/ReadingListDbHelperTest.java
1 file changed, 54 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/41/399541/1
diff --git
a/app/src/androidTest/java/org/wikipedia/readinglist/database/ReadingListDbHelperTest.java
b/app/src/androidTest/java/org/wikipedia/readinglist/database/ReadingListDbHelperTest.java
new file mode 100644
index 0000000..100dc11
--- /dev/null
+++
b/app/src/androidTest/java/org/wikipedia/readinglist/database/ReadingListDbHelperTest.java
@@ -0,0 +1,54 @@
+package org.wikipedia.readinglist.database;
+
+import junit.framework.Assert;
+
+import org.junit.experimental.theories.Theory;
+import org.wikipedia.WikipediaApp;
+import org.wikipedia.page.PageTitle;
+import org.wikipedia.test.view.ViewTest;
+
+import java.util.ArrayList;
+import java.util.List;
+
+public class ReadingListDbHelperTest extends ViewTest {
+ private ReadingListDbHelper readingListDbHelper =
ReadingListDbHelper.instance();
+
+ @Theory
+ public void testForCodeCoverage() {
+ List<ReadingList> list = readingListDbHelper.getAllLists();
+ for (ReadingList readingList : list) {
+ readingListDbHelper.deleteList(readingList);
+ }
+ list = readingListDbHelper.getAllLists();
+ Assert.assertTrue(list.size() == 0);
+ readingListDbHelper.createList("dummy", "This is a dummy");
+ Assert.assertTrue(readingListDbHelper.getAllLists().size() == 1);
+ list = readingListDbHelper.getAllLists();
+ ReadingList readingList = list.get(0);
+ Assert.assertEquals(readingList.title(), "dummy");
+ readingList.title("dummy update");
+ readingListDbHelper.updateList(readingList);
+ list = readingListDbHelper.getAllLists();
+ readingList = list.get(0);
+ Assert.assertEquals(readingList.title(), "dummy update");
+ PageTitle pageTitle = new PageTitle("Barack Obama",
WikipediaApp.getInstance().getWikiSite());
+ List<ReadingListPage> readingListPages = new ArrayList<>();
+ readingListPages.add(new ReadingListPage(pageTitle));
+ readingListDbHelper.addPagesToList(readingList, readingListPages);
+ Assert.assertTrue(readingListDbHelper.findPageInAnyList(pageTitle) !=
null);
+ Assert.assertTrue(readingListDbHelper.pageExistsInList(readingList,
pageTitle));
+ readingListDbHelper.createList("dummy2", "This is a dummy2");
+
readingListDbHelper.addPagesToList(readingListDbHelper.getAllLists().get(1),
readingListPages);
+ readingListDbHelper.createList("dummy3", "This is a dummy3");
+
Assert.assertTrue(readingListDbHelper.getAllListsWithoutContents().size() == 3);
+ List<PageTitle> pageTitlesList = new ArrayList<>();
+ pageTitlesList.add(pageTitle);
+
Assert.assertTrue(readingListDbHelper.addPagesToListIfNotExist(readingList,
pageTitlesList) == 0);
+ Assert.assertTrue(readingListDbHelper.getRandomPage() != null &&
readingListDbHelper.getRandomPage() instanceof ReadingListPage);
+
/*Assert.assertTrue(readingListDbHelper.getAllPageOccurrences(pageTitle).size()
== 2); //returning 1
+
Assert.assertTrue(readingListDbHelper.getListsFromPageOccurrences(readingListPages).size()
== 2); // returning 22*/
+ for (ReadingList readingListToDel : readingListDbHelper.getAllLists())
+ readingListDbHelper.deleteList(readingListToDel);
+ Assert.assertTrue(readingListDbHelper.getAllLists().size() == 0);
+ }
+}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/399541
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75307babfe4914ac6bbe840963d0fca94dcf13f6
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Sharvaniharan <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
