jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/399257 )

Change subject: Add CodeMirror support
......................................................................


Add CodeMirror support

CM uses ContentEditable divs on every browser other
than Firefox so CharInsert needs to work with these.
Not using a generic [contenteditable] selector because
not every surface supports jquery.textSelection.

Works with I72d7d72b2a891a0ad242a565dddc076fa6dd1bd1

Bug: T179287
Change-Id: I113394a473e8fe534f17815676ec7014203db7d6
---
M modules/ext.charinsert.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Kaldari: Looks good to me, approved



diff --git a/modules/ext.charinsert.js b/modules/ext.charinsert.js
index 78de492..dcfa6c3 100644
--- a/modules/ext.charinsert.js
+++ b/modules/ext.charinsert.js
@@ -2,7 +2,7 @@
        var addClickHandlers = function ( $content ) {
                var $currentFocused = $( 'wpTextbox1' );
                // Apply to dynamically created textboxes as well as normal ones
-               $( document ).on( 'focus', 'textarea, input:text', function () {
+               $( document ).on( 'focus', 'textarea, input:text, .CodeMirror', 
function () {
                        $currentFocused = $( this );
                } );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/399257
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I113394a473e8fe534f17815676ec7014203db7d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CharInsert
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Niharika29 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to