jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/399352 )
Change subject: Fix sidebar regression
......................................................................
Fix sidebar regression
- After removing clearfix on dashboard wrapper in Idee6714287,
the wrapper collapsed because of floated children, which in turn
introduced regression of sidebar not becoming sticky on scroll.
Change-Id: Ie6de5eaf97084a3bc9510a930db88dbeb23e60b6
---
M modules/dashboard/styles/ext.cx.dashboard.less
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
jenkins-bot: Verified
Nikerabbit: Checked; Looks good to me, approved
diff --git a/modules/dashboard/styles/ext.cx.dashboard.less
b/modules/dashboard/styles/ext.cx.dashboard.less
index 541550b..9c88a70 100644
--- a/modules/dashboard/styles/ext.cx.dashboard.less
+++ b/modules/dashboard/styles/ext.cx.dashboard.less
@@ -14,6 +14,18 @@
@media only screen and ( max-width: ( @very-narrow - 1px ) ) {
padding: 20px 12px;
}
+
+ /* Clearfix */
+ &:after {
+ // Non empty content value avoids an Opera bug that creates
space around
+ // clearfixed elements if the contenteditable attribute is also
present
+ // somewhere in the HTML.
+ content: ' ';
+ visibility: hidden;
+ display: block;
+ height: 0;
+ clear: both;
+ }
}
.cx-dashboard-sidebar {
--
To view, visit https://gerrit.wikimedia.org/r/399352
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6de5eaf97084a3bc9510a930db88dbeb23e60b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Petar.petkovic <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
