Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399703 )
Change subject: [MCR] Fix RevisionInsertComplete Revision pass by reference ...................................................................... [MCR] Fix RevisionInsertComplete Revision pass by reference This was broken in: 6af796f3e0cf3e66cd7d7e59af8445f5712d68fe Ia4c20a91e98df0b9b14b138eb4825c55e5200384 https://gerrit.wikimedia.org/r/#/c/399174/7 Bug: T183503 Change-Id: I674493507ca4aa6677a3bab7a01d6dc3c2cdbc5b --- M includes/Revision.php 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/03/399703/1 diff --git a/includes/Revision.php b/includes/Revision.php index ea73a61..15130a6 100644 --- a/includes/Revision.php +++ b/includes/Revision.php @@ -979,8 +979,11 @@ $this->mRecord = $rec; + + // Avoid PHP 7.1 warning of passing $this by reference + $revision = $this; // TODO: hard-deprecate in 1.32 (or even 1.31?) - Hooks::run( 'RevisionInsertComplete', [ $this, null, null ] ); + Hooks::run( 'RevisionInsertComplete', [ &$revision, null, null ] ); return $rec->getId(); } -- To view, visit https://gerrit.wikimedia.org/r/399703 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I674493507ca4aa6677a3bab7a01d6dc3c2cdbc5b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Addshore <addshorew...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
