Sharvaniharan has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399810 )
Change subject: On-this-day minor ui fix
......................................................................
On-this-day minor ui fix
- Fixes the month string style
- Fixes indicator date displayed.
Bug: T180372
Change-Id: I92bc6ad78e8d5452a6497f04f64c14ba854db079
---
M app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayFragment.java
M app/src/main/res/layout/date_picker_dialog.xml
2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/10/399810/1
diff --git
a/app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayFragment.java
b/app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayFragment.java
index c28d915..d850aee 100644
--- a/app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayFragment.java
+++ b/app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayFragment.java
@@ -186,7 +186,8 @@
getAppCompatActivity().getSupportActionBar().setTitle("");
collapsingToolbarLayout.setCollapsedTitleTextColor(Color.WHITE);
dayText.setText(DateUtil.getMonthOnlyDateString(date.getTime()));
- indicatorDate.setText(String.format(Locale.getDefault(), "%d",
date.get(Calendar.DATE)));
+ indicatorLayout.setAlpha((date.get(Calendar.MONTH) ==
Calendar.getInstance().get(Calendar.MONTH) && date.get(Calendar.DATE) ==
Calendar.getInstance().get(Calendar.DATE)) ? HALF_ALPHA : 1.0f);
+ indicatorDate.setText(String.format(Locale.getDefault(), "%d",
Calendar.getInstance().get(Calendar.DATE)));
appBarLayout.addOnOffsetChangedListener((appBarLayout, verticalOffset)
-> {
if (verticalOffset > -appBarLayout.getTotalScrollRange()) {
toolbarDay.setText("");
@@ -228,7 +229,7 @@
public void onDatePicked(int month, int day) {
eventsRecycler.setVisibility(View.GONE);
progressBar.setVisibility(View.VISIBLE);
- if (date.get(Calendar.MONTH) != month || date.get(Calendar.DATE) !=
day) {
+ if (Calendar.getInstance().get(Calendar.MONTH) != month ||
Calendar.getInstance().get(Calendar.DATE) != day) {
indicatorLayout.setAlpha(1.0f);
indicatorLayout.setClickable(true);
}
diff --git a/app/src/main/res/layout/date_picker_dialog.xml
b/app/src/main/res/layout/date_picker_dialog.xml
index 205f96e..a50cbc3 100644
--- a/app/src/main/res/layout/date_picker_dialog.xml
+++ b/app/src/main/res/layout/date_picker_dialog.xml
@@ -67,7 +67,7 @@
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_weight="1"
- android:fontFamily="sans-serif"
+ android:fontFamily="sans-serif-medium"
android:gravity="center"
android:layout_gravity="center_vertical"
android:text=""
--
To view, visit https://gerrit.wikimedia.org/r/399810
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92bc6ad78e8d5452a6497f04f64c14ba854db079
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Sharvaniharan <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
