jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/399847 )
Change subject: RCLFilters: support longer page names
......................................................................
RCLFilters: support longer page names
* Make target page selector at least 400px wide
* Set the page name as title (tooltip)
Bug: T183484
Change-Id: Ife806c0b5e5c2ab6e9be32194804e89daaf8b71c
---
M resources/Resources.php
A
resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclTargetPageWidget.less
M
resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclToOrFromWidget.less
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.RclTargetPageWidget.js
4 files changed, 8 insertions(+), 4 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/Resources.php b/resources/Resources.php
index b494429..2dd710d 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1842,6 +1842,7 @@
'resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.LiveUpdateButtonWidget.less',
'resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RcTopSectionWidget.less',
'resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclToOrFromWidget.less',
+
'resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclTargetPageWidget.less',
'resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.WatchlistTopSectionWidget.less',
],
'skinStyles' => [
diff --git
a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclTargetPageWidget.less
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclTargetPageWidget.less
new file mode 100644
index 0000000..2d92e27
--- /dev/null
+++
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclTargetPageWidget.less
@@ -0,0 +1,3 @@
+.mw-rcfilters-ui-rclTargetPageWidget {
+ min-width: 400px;
+}
diff --git
a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclToOrFromWidget.less
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclToOrFromWidget.less
index af01f68..d63f35b 100644
---
a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclToOrFromWidget.less
+++
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclToOrFromWidget.less
@@ -1,6 +1,4 @@
.mw-rcfilters-ui-rclToOrFromWidget {
- min-width: 340px;
-
// need to be very specific to override bg-color
&.oo-ui-dropdownWidget.oo-ui-widget-enabled {
.oo-ui-dropdownWidget-handle {
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.RclTargetPageWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.RclTargetPageWidget.js
index d5c5e26..527d790 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.RclTargetPageWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.RclTargetPageWidget.js
@@ -71,7 +71,9 @@
* Respond to the model being updated
*/
mw.rcfilters.ui.RclTargetPageWidget.prototype.updateUiBasedOnModel =
function () {
- var title = mw.Title.newFromText( this.model.getValue() );
- this.titleSearch.setValue( title ? title.toText() :
this.model.getValue() );
+ var title = mw.Title.newFromText( this.model.getValue() ),
+ text = title ? title.toText() : this.model.getValue();
+ this.titleSearch.setValue( text );
+ this.titleSearch.setTitle( text );
};
}( mediaWiki ) );
--
To view, visit https://gerrit.wikimedia.org/r/399847
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife806c0b5e5c2ab6e9be32194804e89daaf8b71c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
