jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/399888 )
Change subject: Follow-up c7ef30a30f6: append multi-element nodes in the right
order
......................................................................
Follow-up c7ef30a30f6: append multi-element nodes in the right order
The old onSplice code did this correctly, but c7ef30a30f6 reversed the
direction of the loop and it slipped right past me in review.
Bug: T183590
Change-Id: I2a7172a7aeb373a48887f3bfbdec6b82a60fdc94
---
M src/ce/ve.ce.BranchNode.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/ve.ce.BranchNode.js b/src/ce/ve.ce.BranchNode.js
index 9b2420f..0520951 100644
--- a/src/ce/ve.ce.BranchNode.js
+++ b/src/ce/ve.ce.BranchNode.js
@@ -202,7 +202,7 @@
position = this.getDomPosition( index );
for ( i = args.length - 1; i >= 2; i-- ) {
args[ i ].attach( this );
- for ( j = 0, length = args[ i ].$element.length; j <
length; j++ ) {
+ for ( j = args[ i ].$element.length - 1; j >= 0; j-- ) {
position.node.insertBefore(
args[ i ].$element[ j ],
position.node.children[ position.offset
]
--
To view, visit https://gerrit.wikimedia.org/r/399888
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a7172a7aeb373a48887f3bfbdec6b82a60fdc94
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Divec <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
