Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/400269 )
Change subject: build: Stop using 'grunt-image' for optimizing PNGs
......................................................................
build: Stop using 'grunt-image' for optimizing PNGs
This package is very unreliable. Right now it is preventing us from
making a release.
There is very little benefit from keeping it. All modern browsers
today support SVG and don't even load the PNGs. In WMF production we
actually don't use most of the generated PNGs at all, as MediaWiki
does its own rasterization.
Bug: T179992
Change-Id: I0adf5b64e1929eb35cd57d9f07f1122ba4f387aa
---
M Gruntfile.js
M package.json
2 files changed, 1 insertion(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/69/400269/1
diff --git a/Gruntfile.js b/Gruntfile.js
index 2d98d29..92ea570 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -30,7 +30,6 @@
grunt.loadNpmTasks( 'grunt-cssjanus' );
grunt.loadNpmTasks( 'grunt-exec' );
grunt.loadNpmTasks( 'grunt-file-exists' );
- grunt.loadNpmTasks( 'grunt-image' );
grunt.loadNpmTasks( 'grunt-jsonlint' );
grunt.loadNpmTasks( 'grunt-karma' );
grunt.loadNpmTasks( 'grunt-stylelint' );
@@ -340,19 +339,6 @@
src: []
}
},
- image: {
- dist: {
- options: {
- zopflipng: true,
- pngout: true,
- optipng: true,
- advpng: true,
- pngcrush: true
- },
- expand: true,
- src: 'dist/**/*.png'
- }
- },
cssmin: {
options: {
keepSpecialComments: 0,
@@ -636,7 +622,7 @@
] );
// Minification tasks for the npm publish step
- grunt.registerTask( 'minify', [ 'uglify', 'image', 'cssmin' ] );
+ grunt.registerTask( 'minify', [ 'uglify', 'cssmin' ] );
grunt.registerTask( 'publish-build', [ 'build', 'minify' ] );
grunt.registerTask( 'lint', [ 'eslint', 'stylelint', 'jsonlint',
'banana' ] );
diff --git a/package.json b/package.json
index 0e10483..eccbdd6 100644
--- a/package.json
+++ b/package.json
@@ -42,7 +42,6 @@
"grunt-eslint": "20.1.0",
"grunt-exec": "1.0.1",
"grunt-file-exists": "0.1.4",
- "grunt-image": "4.0.0",
"grunt-jsonlint": "1.1.0",
"grunt-karma": "2.0.0",
"grunt-promise-q":
"git://github.com/jdforrester/grunt-promise-q.git#v0.1.1-wmf.1",
--
To view, visit https://gerrit.wikimedia.org/r/400269
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0adf5b64e1929eb35cd57d9f07f1122ba4f387aa
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
