Hello Paladox, Chad, Reedy, Pmiazga, Addshore, Legoktm, jenkins-bot, VolkerE,
Jdlrobson, Jforrester,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/400389
to review the following change.
Change subject: Revert "Revert "Print styles in Vector are no longer feature
flagged""
......................................................................
Revert "Revert "Print styles in Vector are no longer feature flagged""
The revert looks like it has been performed incorrectly,
and I found a much better solution to the task anyway.
This reverts commit 7d2fc6df27d46b28081e1834c80b913eee48ed69.
Bug: T178028
Bug: T183640
Change-Id: Ib46c69b061b522fc6365459297ad3f3d4f4d0d0d
---
M SkinVector.php
M skin.json
2 files changed, 4 insertions(+), 23 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector
refs/changes/89/400389/1
diff --git a/SkinVector.php b/SkinVector.php
index 23dd944..5dd6ef2 100644
--- a/SkinVector.php
+++ b/SkinVector.php
@@ -44,10 +44,6 @@
/** @inheritDoc */
public function getPageClasses( $title ) {
$className = parent::getPageClasses( $title );
- if ( $this->vectorConfig->get( 'VectorExperimentalPrintStyles'
) ) {
- $className .= ' vector-experimental-print-styles';
- }
- $className .= ' vector-nav-directionality';
return $className;
}
@@ -72,14 +68,6 @@
if ( $this->vectorConfig->get( 'VectorResponsive' ) ) {
$this->enableResponsiveMode();
- }
-
- // Print styles are feature flagged.
- // This flag can be removed when T169732 is resolved.
- if ( $this->vectorConfig->get( 'VectorExperimentalPrintStyles'
) ) {
- // Note, when deploying (T169732) we'll want to fold
the stylesheet into
- // skins.vector.styles and remove this module
altogether.
- $out->addModuleStyles(
'skins.vector.styles.experimental.print' );
}
$out->addModules( 'skins.vector.js' );
diff --git a/skin.json b/skin.json
index 47bdb50..b2b079f 100644
--- a/skin.json
+++ b/skin.json
@@ -38,6 +38,7 @@
"@note": "When modifying skins.vector.styles definition, make sure the
installer still works",
"ResourceModules": {
"skins.vector.styles": {
+ "class": "Vector\\ResourceLoaderLessModule",
"targets": [ "desktop", "mobile" ],
"position": "top",
"styles": {
@@ -46,17 +47,11 @@
},
"screen-hd.less": {
"media": "screen and (min-width: 982px)"
- }
+ },
+ "print.less": {}
}
},
- "skins.vector.styles.experimental.print": {
- "class": "Vector\\ResourceLoaderLessModule",
- "targets": [ "desktop", "mobile" ],
- "position": "top",
- "styles": [
- "print.less"
- ]
- },
+
"skins.vector.styles.responsive": {
"targets": [ "desktop", "mobile" ],
"position": "top",
@@ -110,8 +105,6 @@
"config": {
"VectorUseSimpleSearch": true,
"VectorUseIconWatch": true,
- "@VectorExperimentalPrintStyles": "Temporary config variable to
feature flag new print styles (T154965)",
- "VectorExperimentalPrintStyles": false,
"VectorResponsive": false,
"VectorPrintLogo": false
},
--
To view, visit https://gerrit.wikimedia.org/r/400389
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib46c69b061b522fc6365459297ad3f3d4f4d0d0d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: Pmiazga <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
