Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/400390 )
Change subject: Do not fail when we can't get the config
......................................................................
Do not fail when we can't get the config
Config is not available when running in the context of the MediaWiki
installer.
Bug: T183640
Change-Id: Iaf3fa508fb71e93570120134f7c44001f5833f1c
---
M ResourceLoaderLessModule.php
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector
refs/changes/90/400390/1
diff --git a/ResourceLoaderLessModule.php b/ResourceLoaderLessModule.php
index 38eb06a..37f6716 100644
--- a/ResourceLoaderLessModule.php
+++ b/ResourceLoaderLessModule.php
@@ -24,6 +24,7 @@
use CSSMin;
use MediaWiki\MediaWikiServices;
+use ConfigException;
use ResourceLoaderContext;
use ResourceLoaderFileModule;
@@ -39,8 +40,13 @@
*/
protected function getLessVars( ResourceLoaderContext $context ) {
$lessVars = parent::getLessVars( $context );
- $config =
MediaWikiServices::getInstance()->getConfigFactory()->makeConfig( 'vector' );
- $printLogo = $config->get( 'VectorPrintLogo' );
+ try {
+ $config =
MediaWikiServices::getInstance()->getConfigFactory()->makeConfig( 'vector' );
+ $printLogo = $config->get( 'VectorPrintLogo' );
+ } catch ( ConfigException $e ) {
+ // Config is not available when running in the context
of the MediaWiki installer. (T183640)
+ $printLogo = false;
+ }
if ( $printLogo ) {
$lessVars[ 'printLogo' ] = true;
$lessVars[ 'printLogoUrl' ] = CSSMin::buildUrlValue(
$printLogo['url'] );
--
To view, visit https://gerrit.wikimedia.org/r/400390
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf3fa508fb71e93570120134f7c44001f5833f1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
