jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/393093 )
Change subject: Use StatementChanger in ControllerViewfactory for Form
Statements
......................................................................
Use StatementChanger in ControllerViewfactory for Form Statements
Note that:
fireHook( 'wikibase.statement.saved', self._entity.getId(), guid )
will us entityId of Lexeme!
Bug: T181253
Change-Id: I4b3ca9f3931b537e4ee261101ac27250c0b989e3
---
M resources/view/ControllerViewFactory.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Thiemo Kreuz (WMDE): Looks good to me, approved
diff --git a/resources/view/ControllerViewFactory.js
b/resources/view/ControllerViewFactory.js
index 268ff30..a0552cf 100644
--- a/resources/view/ControllerViewFactory.js
+++ b/resources/view/ControllerViewFactory.js
@@ -47,7 +47,7 @@
$.extend( fakeStatementsChanger,
statementsChanger );
fakeStatementsChanger.save = function
fakeStatementsChangerSave( statement ) {
var guid =
statement.getClaim().getGuid();
- if ( /^L\d+-[FS]\d+/.test( guid ) ||
/^[FS]\d+/.test( guid ) ) {
+ if ( /^(L\d+-)?S\d+\$/.test( guid ) ) {
return $.Deferred().resolve(
statement ).promise();
} else {
return statementsChanger.save(
statement );
--
To view, visit https://gerrit.wikimedia.org/r/393093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b3ca9f3931b537e4ee261101ac27250c0b989e3
Gerrit-PatchSet: 22
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Thiemo Kreuz (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
