jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/400404 )
Change subject: mw.echo.ui.MenuItemWidget: Override OOUI styles harder
......................................................................
mw.echo.ui.MenuItemWidget: Override OOUI styles harder
Bug: T183435
Change-Id: I949de77ac8221bdc4bb35ae7b75e3df91d861d07
---
M modules/styles/mw.echo.ui.MenuItemWidget.less
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
jenkins-bot: Verified
Mooeypoo: Looks good to me, approved
diff --git a/modules/styles/mw.echo.ui.MenuItemWidget.less
b/modules/styles/mw.echo.ui.MenuItemWidget.less
index 77ca9c5..799f8a3 100644
--- a/modules/styles/mw.echo.ui.MenuItemWidget.less
+++ b/modules/styles/mw.echo.ui.MenuItemWidget.less
@@ -1,15 +1,15 @@
@import '../echo.variables';
@import '../echo.mixins';
+/* stylelint-disable no-descending-specificity */
.mw-echo-ui-menuItemWidget {
- &-icon {
+ // Some extra CSS classes to override OOUI styles with a very specific
selector
+ &.oo-ui-iconElement &-icon {
display: inline-block;
- // We have to override oojs-ui's width/height, which uses
- // a very specific selector
- width: 1.5em !important;
- height: 1.5em !important;
- min-width: 1.5em !important;
- min-height: 1.5em !important;
+ width: 1.5em;
+ height: 1.5em;
+ min-width: 1.5em;
+ min-height: 1.5em;
position: absolute;
top: 0;
--
To view, visit https://gerrit.wikimedia.org/r/400404
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I949de77ac8221bdc4bb35ae7b75e3df91d861d07
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
