Ebe123 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/400463 )
Change subject: Replace class_exists with ExtensionRegistry checks
......................................................................
Replace class_exists with ExtensionRegistry checks
class_exists calls with a string are dangerous, because they violate
the separation between extensions and do not reflect changes that
have been made elsewhere.
Bug: T183096
Change-Id: I8cf99e9d77f4978fe3e88d1c781c77f8b17a42e6
---
M includes/Score.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Score
refs/changes/63/400463/1
diff --git a/includes/Score.php b/includes/Score.php
index e6df438..d7f1381 100644
--- a/includes/Score.php
+++ b/includes/Score.php
@@ -266,7 +266,7 @@
$options['generate_ogg'] = array_key_exists( 'vorbis',
$args );
if ( $options['generate_ogg']
- && !class_exists( 'TimedMediaTransformOutput' )
+ && !ExtensionRegistry::getInstance()->isLoaded(
'TimedMediaHandler' )
) {
throw new ScoreException( wfMessage(
'score-nomediahandler' ) );
}
@@ -896,7 +896,7 @@
*/
private static function getLength( $path ) {
// File_Ogg is packaged in TimedMediaHandler
- if ( !class_exists( 'File_Ogg' ) ) {
+ if ( !ExtensionRegistry::getInstance()->isLoaded(
'TimedMediaHandler' ) ) {
require 'File/Ogg.php';
}
$f = new File_Ogg( $path );
--
To view, visit https://gerrit.wikimedia.org/r/400463
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cf99e9d77f4978fe3e88d1c781c77f8b17a42e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Score
Gerrit-Branch: master
Gerrit-Owner: Ebe123 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
