Subramanya Sastry has submitted this change and it was merged. Change subject: Add note on when native parser functions are used ......................................................................
Add note on when native parser functions are used This should hopefully avoid misunderstandings on when this code is actually used (answer: only in parserTests, and should not really be used there either..). Change-Id: Ica197e1dc2c8847e632da267590cf6180fd83b88 --- M js/lib/ext.core.ParserFunctions.js 1 file changed, 10 insertions(+), 7 deletions(-) Approvals: Subramanya Sastry: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/js/lib/ext.core.ParserFunctions.js b/js/lib/ext.core.ParserFunctions.js index efaded5..427baf6 100644 --- a/js/lib/ext.core.ParserFunctions.js +++ b/js/lib/ext.core.ParserFunctions.js @@ -1,18 +1,21 @@ /* * Some parser functions, and quite a bunch of stubs of parser functions. + * + * IMPORTANT NOTE: These parser functions are only used by the Parsoid-native + * template expansion pipeline, which is *not* the default or used in + * production. Normally we use API calls into a MediaWiki installation to + * implement parser functions and other preprocessor functionality. The only + * use of this code is currently in parserTests, but those tests should + * probably be marked as PHP-only and any mixed testing moved into separate + * tests. This means that there is not much point in spending time on + * implementing more parser functions here. + * * There are still quite a few missing, see * http://www.mediawiki.org/wiki/Help:Magic_words and * http://www.mediawiki.org/wiki/Help:Extension:ParserFunctions. * Instantiated and called by the TemplateHandler extension. Any pf_<prefix> * matching a lower-cased template name prefix up to the first colon will * override that template. - * - * TODO: Implement these more thoroughly, and test against - * extensions/ParserFunction/ - * convertTests.txt - * exprTests.txt - * funcsParserTests.txt - * stringFunctionTests.txt */ "use strict"; -- To view, visit https://gerrit.wikimedia.org/r/57542 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica197e1dc2c8847e632da267590cf6180fd83b88 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: GWicke <[email protected]> Gerrit-Reviewer: Cscott <[email protected]> Gerrit-Reviewer: Subramanya Sastry <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
