LukBukkit has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401095 )
Change subject: Avoid PHP 7.1 warning of &$this usage ...................................................................... Avoid PHP 7.1 warning of &$this usage Bug: T153505 Change-Id: I2a410bdfb0dc063d2c27ee79cc4d67f2d4f603f8 --- M ApexTemplate.php 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/apex refs/changes/95/401095/1 diff --git a/ApexTemplate.php b/ApexTemplate.php index 46a0a19..14f8b32 100644 --- a/ApexTemplate.php +++ b/ApexTemplate.php @@ -224,7 +224,9 @@ <?php endforeach; if ( $hook !== null ) { - Hooks::run( $hook, [ &$this, true ] ); + // Avoid PHP 7.1 warning of passing $this by reference + $template = $this; + Hooks::run( $hook, [ &$template, true ] ); } ?> </ul> -- To view, visit https://gerrit.wikimedia.org/r/401095 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2a410bdfb0dc063d2c27ee79cc4d67f2d4f603f8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/apex Gerrit-Branch: master Gerrit-Owner: LukBukkit <luk.buk...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits