Rafidaslam has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401116 )
Change subject: comms.http: Include HttpRequest.kwargs in session.request call
......................................................................
comms.http: Include HttpRequest.kwargs in session.request call
Include threadedhttp.HttpRequest.kwargs in session.request call in
`_http_process()`.
Before this HttpRequest.kwargs didn't get into session.request call
so if we call a function like `pywikibot.comms.http.fetch()` with
parameter like `stream=True`, the `stream` param would be ignored.
Bug: T183830
Change-Id: I02d71a933bc1ef0073a0ec34534b4eeeefc10e91
---
M pywikibot/comms/http.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/16/401116/1
diff --git a/pywikibot/comms/http.py b/pywikibot/comms/http.py
index b6fb20d..6855195 100644
--- a/pywikibot/comms/http.py
+++ b/pywikibot/comms/http.py
@@ -374,7 +374,8 @@
# verify=True, when a request with verify=False happened before
response = session.request(method, uri, params=params, data=body,
headers=headers, auth=auth, timeout=timeout,
- verify=not ignore_validation)
+ verify=not ignore_validation,
+ **http_request.kwargs)
except Exception as e:
http_request.data = e
else:
--
To view, visit https://gerrit.wikimedia.org/r/401116
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02d71a933bc1ef0073a0ec34534b4eeeefc10e91
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Rafidaslam <rafidt...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
