Christian has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57686
Change subject: Clickable inline images
......................................................................
Clickable inline images
Clicking an inline image will select it, or expand the selection.
Change-Id: I505665f2dac2e52140cc049e63e3355190dcbfec
---
M modules/ve/ce/nodes/ve.ce.MWImageNode.js
1 file changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/86/57686/1
diff --git a/modules/ve/ce/nodes/ve.ce.MWImageNode.js
b/modules/ve/ce/nodes/ve.ce.MWImageNode.js
index 701a884..f7beff6 100644
--- a/modules/ve/ce/nodes/ve.ce.MWImageNode.js
+++ b/modules/ve/ce/nodes/ve.ce.MWImageNode.js
@@ -59,8 +59,20 @@
* @param {jQuery.Event} e Click event
*/
ve.ce.MWImageNode.prototype.onClick = function ( e ) {
- e.preventDefault();
- return false;
+ var range,
+ surfaceModel = this.getRoot().getSurface().getModel(),
+ selection = surfaceModel.getSelection();
+
+ range = new ve.Range(
+ this.model.getOffset(),
+ this.model.getOffset() + this.model.getOuterLength()
+ );
+
+ if ( e.shiftKey ) {
+ range = ve.Range.newCoveringRange( [ selection, range ] );
+ }
+
+ this.getRoot().getSurface().getModel().change( null, range );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/57686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I505665f2dac2e52140cc049e63e3355190dcbfec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Christian <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
