jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400748 )
Change subject: Use MediaWikiCoversValidator for tests that don't use MediaWikiTestCase ...................................................................... Use MediaWikiCoversValidator for tests that don't use MediaWikiTestCase Change-Id: I8c4de7e9c72c9969088666007b54c6fd23f6cc13 --- M tests/phpunit/includes/FauxRequestTest.php M tests/phpunit/includes/MediaWikiVersionFetcherTest.php M tests/phpunit/includes/SanitizerValidateEmailTest.php M tests/phpunit/includes/TitleArrayFromResultTest.php M tests/phpunit/includes/WikiReferenceTest.php M tests/phpunit/includes/XmlJsTest.php M tests/phpunit/includes/composer/ComposerVersionNormalizerTest.php M tests/phpunit/includes/config/EtcdConfigTest.php M tests/phpunit/includes/deferred/MWCallableUpdateTest.php M tests/phpunit/includes/deferred/TransactionRoundDefiningUpdateTest.php M tests/phpunit/includes/externalstore/ExternalStoreFactoryTest.php M tests/phpunit/includes/htmlform/HTMLRestrictionsFieldTest.php M tests/phpunit/includes/jobqueue/JobQueueMemoryTest.php M tests/phpunit/includes/libs/ArrayUtilsTest.php M tests/phpunit/includes/libs/DeferredStringifierTest.php M tests/phpunit/includes/libs/DnsSrvDiscovererTest.php M tests/phpunit/includes/libs/GenericArrayObjectTest.php M tests/phpunit/includes/libs/HashRingTest.php M tests/phpunit/includes/libs/HtmlArmorTest.php M tests/phpunit/includes/libs/IEUrlExtensionTest.php M tests/phpunit/includes/libs/IPTest.php M tests/phpunit/includes/libs/JavaScriptMinifierTest.php M tests/phpunit/includes/libs/MWMessagePackTest.php M tests/phpunit/includes/libs/MapCacheLRUTest.php M tests/phpunit/includes/libs/MemoizedCallableTest.php M tests/phpunit/includes/libs/ObjectFactoryTest.php M tests/phpunit/includes/libs/ProcessCacheLRUTest.php M tests/phpunit/includes/libs/SamplingStatsdClientTest.php M tests/phpunit/includes/libs/StringUtilsTest.php M tests/phpunit/includes/libs/TimingTest.php M tests/phpunit/includes/libs/XhprofDataTest.php M tests/phpunit/includes/libs/XhprofTest.php M tests/phpunit/includes/libs/XmlTypeCheckTest.php M tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php M tests/phpunit/includes/libs/objectcache/CachedBagOStuffTest.php M tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php M tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php M tests/phpunit/includes/libs/rdbms/TransactionProfilerTest.php M tests/phpunit/includes/libs/rdbms/database/DatabaseDomainTest.php M tests/phpunit/includes/libs/rdbms/database/DatabaseMysqlBaseTest.php M tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php M tests/phpunit/includes/libs/rdbms/database/DatabaseTest.php M tests/phpunit/includes/libs/xmp/XMPTest.php M tests/phpunit/includes/libs/xmp/XMPValidateTest.php M tests/phpunit/includes/objectcache/RedisBagOStuffTest.php M tests/phpunit/includes/parser/ParserIntegrationTest.php M tests/phpunit/includes/registration/VersionCheckerTest.php M tests/phpunit/includes/resourceloader/DerivativeResourceLoaderContextTest.php M tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php M tests/phpunit/includes/resourceloader/ResourceLoaderClientHtmlTest.php M tests/phpunit/includes/resourceloader/ResourceLoaderContextTest.php M tests/phpunit/includes/resourceloader/ResourceLoaderSkinModuleTest.php M tests/phpunit/includes/services/ServiceContainerTest.php M tests/phpunit/includes/shell/CommandFactoryTest.php M tests/phpunit/includes/shell/CommandTest.php M tests/phpunit/includes/shell/FirejailCommandTest.php M tests/phpunit/includes/shell/ShellTest.php M tests/phpunit/includes/site/FileBasedSiteLookupTest.php M tests/phpunit/includes/site/MediaWikiPageNameNormalizerTest.php M tests/phpunit/includes/site/SiteExporterTest.php M tests/phpunit/includes/site/SiteImporterTest.php M tests/phpunit/includes/site/SitesCacheFileBuilderTest.php M tests/phpunit/includes/utils/AvroValidatorTest.php M tests/phpunit/includes/utils/ClassCollectorTest.php M tests/phpunit/includes/utils/FileContentsHasherTest.php M tests/phpunit/includes/utils/MWCryptHashTest.php M tests/phpunit/includes/utils/MWRestrictionsTest.php M tests/phpunit/includes/utils/UIDGeneratorTest.php M tests/phpunit/includes/utils/ZipDirectoryReaderTest.php M tests/phpunit/includes/watcheditem/WatchedItemQueryServiceUnitTest.php M tests/phpunit/languages/LanguageCodeTest.php M tests/phpunit/maintenance/BenchmarkerTest.php M tests/phpunit/structure/AvailableRightsTest.php M tests/phpunit/structure/ExtensionJsonValidationTest.php 74 files changed, 176 insertions(+), 0 deletions(-) Approvals: Umherirrender: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/phpunit/includes/FauxRequestTest.php b/tests/phpunit/includes/FauxRequestTest.php index 9fe694d..e39dcdb 100644 --- a/tests/phpunit/includes/FauxRequestTest.php +++ b/tests/phpunit/includes/FauxRequestTest.php @@ -3,6 +3,9 @@ use MediaWiki\Session\SessionManager; class FauxRequestTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** * @covers FauxRequest::__construct */ diff --git a/tests/phpunit/includes/MediaWikiVersionFetcherTest.php b/tests/phpunit/includes/MediaWikiVersionFetcherTest.php index fa59ef2..6aa9849 100644 --- a/tests/phpunit/includes/MediaWikiVersionFetcherTest.php +++ b/tests/phpunit/includes/MediaWikiVersionFetcherTest.php @@ -12,6 +12,8 @@ */ class MediaWikiVersionFetcherTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + public function testReturnsResult() { $versionFetcher = new MediaWikiVersionFetcher(); $this->assertInternalType( 'string', $versionFetcher->fetchVersion() ); diff --git a/tests/phpunit/includes/SanitizerValidateEmailTest.php b/tests/phpunit/includes/SanitizerValidateEmailTest.php index 2448513..c7e15ea 100644 --- a/tests/phpunit/includes/SanitizerValidateEmailTest.php +++ b/tests/phpunit/includes/SanitizerValidateEmailTest.php @@ -7,6 +7,8 @@ */ class SanitizerValidateEmailTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + private function checkEmail( $addr, $expected = true, $msg = '' ) { if ( $msg == '' ) { $msg = "Testing $addr"; diff --git a/tests/phpunit/includes/TitleArrayFromResultTest.php b/tests/phpunit/includes/TitleArrayFromResultTest.php index 7c2973f..8882214 100644 --- a/tests/phpunit/includes/TitleArrayFromResultTest.php +++ b/tests/phpunit/includes/TitleArrayFromResultTest.php @@ -6,6 +6,8 @@ */ class TitleArrayFromResultTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + private function getMockResultWrapper( $row = null, $numRows = 1 ) { $resultWrapper = $this->getMockBuilder( 'ResultWrapper' ) ->disableOriginalConstructor(); diff --git a/tests/phpunit/includes/WikiReferenceTest.php b/tests/phpunit/includes/WikiReferenceTest.php index 724dd60..227dd87 100644 --- a/tests/phpunit/includes/WikiReferenceTest.php +++ b/tests/phpunit/includes/WikiReferenceTest.php @@ -6,6 +6,8 @@ class WikiReferenceTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + public function provideGetDisplayName() { return [ 'http' => [ 'foo.bar', 'http://foo.bar' ], diff --git a/tests/phpunit/includes/XmlJsTest.php b/tests/phpunit/includes/XmlJsTest.php index c2bc73e..dec7bf3 100644 --- a/tests/phpunit/includes/XmlJsTest.php +++ b/tests/phpunit/includes/XmlJsTest.php @@ -5,6 +5,8 @@ */ class XmlJsTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @covers XmlJsCode::__construct * @dataProvider provideConstruction diff --git a/tests/phpunit/includes/composer/ComposerVersionNormalizerTest.php b/tests/phpunit/includes/composer/ComposerVersionNormalizerTest.php index 8a2ebaf..a4cc446 100644 --- a/tests/phpunit/includes/composer/ComposerVersionNormalizerTest.php +++ b/tests/phpunit/includes/composer/ComposerVersionNormalizerTest.php @@ -9,6 +9,8 @@ */ class ComposerVersionNormalizerTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @dataProvider nonStringProvider */ diff --git a/tests/phpunit/includes/config/EtcdConfigTest.php b/tests/phpunit/includes/config/EtcdConfigTest.php index 3e70a07..7a4d9d9 100644 --- a/tests/phpunit/includes/config/EtcdConfigTest.php +++ b/tests/phpunit/includes/config/EtcdConfigTest.php @@ -4,6 +4,8 @@ class EtcdConfigTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + private function createConfigMock( array $options = [] ) { return $this->getMockBuilder( EtcdConfig::class ) ->setConstructorArgs( [ $options + [ diff --git a/tests/phpunit/includes/deferred/MWCallableUpdateTest.php b/tests/phpunit/includes/deferred/MWCallableUpdateTest.php index 6995bf8..088ab4f 100644 --- a/tests/phpunit/includes/deferred/MWCallableUpdateTest.php +++ b/tests/phpunit/includes/deferred/MWCallableUpdateTest.php @@ -5,6 +5,8 @@ */ class MWCallableUpdateTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + public function testDoUpdate() { $ran = 0; $update = new MWCallableUpdate( function () use ( &$ran ) { diff --git a/tests/phpunit/includes/deferred/TransactionRoundDefiningUpdateTest.php b/tests/phpunit/includes/deferred/TransactionRoundDefiningUpdateTest.php index e6ad072..1261c24 100644 --- a/tests/phpunit/includes/deferred/TransactionRoundDefiningUpdateTest.php +++ b/tests/phpunit/includes/deferred/TransactionRoundDefiningUpdateTest.php @@ -5,6 +5,8 @@ */ class TransactionRoundDefiningUpdateTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + public function testDoUpdate() { $ran = 0; $update = new TransactionRoundDefiningUpdate( function () use ( &$ran ) { diff --git a/tests/phpunit/includes/externalstore/ExternalStoreFactoryTest.php b/tests/phpunit/includes/externalstore/ExternalStoreFactoryTest.php index a0bac63..d43e04a 100644 --- a/tests/phpunit/includes/externalstore/ExternalStoreFactoryTest.php +++ b/tests/phpunit/includes/externalstore/ExternalStoreFactoryTest.php @@ -5,6 +5,8 @@ */ class ExternalStoreFactoryTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + public function testExternalStoreFactory_noStores() { $factory = new ExternalStoreFactory( [] ); $this->assertFalse( $factory->getStoreObject( 'ForTesting' ) ); diff --git a/tests/phpunit/includes/htmlform/HTMLRestrictionsFieldTest.php b/tests/phpunit/includes/htmlform/HTMLRestrictionsFieldTest.php index 9ec4f97..13c92e3 100644 --- a/tests/phpunit/includes/htmlform/HTMLRestrictionsFieldTest.php +++ b/tests/phpunit/includes/htmlform/HTMLRestrictionsFieldTest.php @@ -1,6 +1,9 @@ <?php class HTMLRestrictionsFieldTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + public function testConstruct() { $field = new HTMLRestrictionsField( [ 'fieldname' => 'restrictions' ] ); $this->assertNotEmpty( $field->getLabel(), 'has a default label' ); diff --git a/tests/phpunit/includes/jobqueue/JobQueueMemoryTest.php b/tests/phpunit/includes/jobqueue/JobQueueMemoryTest.php index fe7c506..edba75ce 100644 --- a/tests/phpunit/includes/jobqueue/JobQueueMemoryTest.php +++ b/tests/phpunit/includes/jobqueue/JobQueueMemoryTest.php @@ -10,6 +10,8 @@ */ class JobQueueMemoryTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @return JobQueueMemory */ diff --git a/tests/phpunit/includes/libs/ArrayUtilsTest.php b/tests/phpunit/includes/libs/ArrayUtilsTest.php index 21472d5..76b4ee1 100644 --- a/tests/phpunit/includes/libs/ArrayUtilsTest.php +++ b/tests/phpunit/includes/libs/ArrayUtilsTest.php @@ -6,6 +6,9 @@ */ class ArrayUtilsTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + private $search; /** diff --git a/tests/phpunit/includes/libs/DeferredStringifierTest.php b/tests/phpunit/includes/libs/DeferredStringifierTest.php index cba2939..c3a1285 100644 --- a/tests/phpunit/includes/libs/DeferredStringifierTest.php +++ b/tests/phpunit/includes/libs/DeferredStringifierTest.php @@ -2,6 +2,8 @@ class DeferredStringifierTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @covers DeferredStringifier * @dataProvider provideToString diff --git a/tests/phpunit/includes/libs/DnsSrvDiscovererTest.php b/tests/phpunit/includes/libs/DnsSrvDiscovererTest.php index cfc2d91..bc20c4c 100644 --- a/tests/phpunit/includes/libs/DnsSrvDiscovererTest.php +++ b/tests/phpunit/includes/libs/DnsSrvDiscovererTest.php @@ -1,6 +1,9 @@ <?php class DnsSrvDiscovererTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** * @covers DnsSrvDiscoverer * @dataProvider provideRecords diff --git a/tests/phpunit/includes/libs/GenericArrayObjectTest.php b/tests/phpunit/includes/libs/GenericArrayObjectTest.php index 12c5787..3e8aaeb 100644 --- a/tests/phpunit/includes/libs/GenericArrayObjectTest.php +++ b/tests/phpunit/includes/libs/GenericArrayObjectTest.php @@ -28,6 +28,8 @@ */ abstract class GenericArrayObjectTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * Returns objects that can serve as elements in the concrete * GenericArrayObject deriving class being tested. diff --git a/tests/phpunit/includes/libs/HashRingTest.php b/tests/phpunit/includes/libs/HashRingTest.php index 0822a8a..040bebf 100644 --- a/tests/phpunit/includes/libs/HashRingTest.php +++ b/tests/phpunit/includes/libs/HashRingTest.php @@ -4,6 +4,9 @@ * @group HashRing */ class HashRingTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** * @covers HashRing */ diff --git a/tests/phpunit/includes/libs/HtmlArmorTest.php b/tests/phpunit/includes/libs/HtmlArmorTest.php index 0e9469a..eb601e7 100644 --- a/tests/phpunit/includes/libs/HtmlArmorTest.php +++ b/tests/phpunit/includes/libs/HtmlArmorTest.php @@ -5,6 +5,8 @@ */ class HtmlArmorTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + public static function provideConstructor() { return [ [ 'test' ], diff --git a/tests/phpunit/includes/libs/IEUrlExtensionTest.php b/tests/phpunit/includes/libs/IEUrlExtensionTest.php index 57668e5..8192f01 100644 --- a/tests/phpunit/includes/libs/IEUrlExtensionTest.php +++ b/tests/phpunit/includes/libs/IEUrlExtensionTest.php @@ -6,6 +6,9 @@ * ...a dataprovider and test method. */ class IEUrlExtensionTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** * @covers IEUrlExtension::findIE6Extension */ diff --git a/tests/phpunit/includes/libs/IPTest.php b/tests/phpunit/includes/libs/IPTest.php index e47c4ba..84e4706 100644 --- a/tests/phpunit/includes/libs/IPTest.php +++ b/tests/phpunit/includes/libs/IPTest.php @@ -10,6 +10,9 @@ */ class IPTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** * @covers IP::isIPAddress * @dataProvider provideInvalidIPs diff --git a/tests/phpunit/includes/libs/JavaScriptMinifierTest.php b/tests/phpunit/includes/libs/JavaScriptMinifierTest.php index 12b2c04..5061e27 100644 --- a/tests/phpunit/includes/libs/JavaScriptMinifierTest.php +++ b/tests/phpunit/includes/libs/JavaScriptMinifierTest.php @@ -2,6 +2,8 @@ class JavaScriptMinifierTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + public static function provideCases() { return [ diff --git a/tests/phpunit/includes/libs/MWMessagePackTest.php b/tests/phpunit/includes/libs/MWMessagePackTest.php index 88dc67a..57c9831 100644 --- a/tests/phpunit/includes/libs/MWMessagePackTest.php +++ b/tests/phpunit/includes/libs/MWMessagePackTest.php @@ -5,6 +5,8 @@ */ class MWMessagePackTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * Provides test cases for MWMessagePackTest::testMessagePack * diff --git a/tests/phpunit/includes/libs/MapCacheLRUTest.php b/tests/phpunit/includes/libs/MapCacheLRUTest.php index 60a5057..363b081 100644 --- a/tests/phpunit/includes/libs/MapCacheLRUTest.php +++ b/tests/phpunit/includes/libs/MapCacheLRUTest.php @@ -3,6 +3,9 @@ * @group Cache */ class MapCacheLRUTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** * @covers MapCacheLRU::newFromArray() * @covers MapCacheLRU::toArray() diff --git a/tests/phpunit/includes/libs/MemoizedCallableTest.php b/tests/phpunit/includes/libs/MemoizedCallableTest.php index d99c587..ba8af93 100644 --- a/tests/phpunit/includes/libs/MemoizedCallableTest.php +++ b/tests/phpunit/includes/libs/MemoizedCallableTest.php @@ -26,6 +26,8 @@ */ class MemoizedCallableTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * The memoized callable should relate inputs to outputs in the same * way as the original underlying callable. diff --git a/tests/phpunit/includes/libs/ObjectFactoryTest.php b/tests/phpunit/includes/libs/ObjectFactoryTest.php index 35a7b60..03814da 100644 --- a/tests/phpunit/includes/libs/ObjectFactoryTest.php +++ b/tests/phpunit/includes/libs/ObjectFactoryTest.php @@ -20,6 +20,8 @@ class ObjectFactoryTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @covers ObjectFactory::getObjectFromSpec */ diff --git a/tests/phpunit/includes/libs/ProcessCacheLRUTest.php b/tests/phpunit/includes/libs/ProcessCacheLRUTest.php index 9c189d1..e027d5b 100644 --- a/tests/phpunit/includes/libs/ProcessCacheLRUTest.php +++ b/tests/phpunit/includes/libs/ProcessCacheLRUTest.php @@ -11,6 +11,8 @@ */ class ProcessCacheLRUTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * Helper to verify emptiness of a cache object. * Compare against an array so we get the cache content difference. diff --git a/tests/phpunit/includes/libs/SamplingStatsdClientTest.php b/tests/phpunit/includes/libs/SamplingStatsdClientTest.php index c5bc03e..cf18aaf 100644 --- a/tests/phpunit/includes/libs/SamplingStatsdClientTest.php +++ b/tests/phpunit/includes/libs/SamplingStatsdClientTest.php @@ -4,6 +4,9 @@ use Liuggio\StatsdClient\Sender\SenderInterface; class SamplingStatsdClientTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** * @dataProvider samplingDataProvider */ diff --git a/tests/phpunit/includes/libs/StringUtilsTest.php b/tests/phpunit/includes/libs/StringUtilsTest.php index 8075944..3e5ccac 100644 --- a/tests/phpunit/includes/libs/StringUtilsTest.php +++ b/tests/phpunit/includes/libs/StringUtilsTest.php @@ -2,6 +2,8 @@ class StringUtilsTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @covers StringUtils::isUtf8 * @dataProvider provideStringsForIsUtf8Check diff --git a/tests/phpunit/includes/libs/TimingTest.php b/tests/phpunit/includes/libs/TimingTest.php index 4d71944..7e166f8 100644 --- a/tests/phpunit/includes/libs/TimingTest.php +++ b/tests/phpunit/includes/libs/TimingTest.php @@ -21,6 +21,8 @@ class TimingTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @covers Timing::clearMarks * @covers Timing::getEntries diff --git a/tests/phpunit/includes/libs/XhprofDataTest.php b/tests/phpunit/includes/libs/XhprofDataTest.php index 35e9005..d226227 100644 --- a/tests/phpunit/includes/libs/XhprofDataTest.php +++ b/tests/phpunit/includes/libs/XhprofDataTest.php @@ -26,6 +26,8 @@ */ class XhprofDataTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @covers XhprofData::splitKey * @dataProvider provideSplitKey diff --git a/tests/phpunit/includes/libs/XhprofTest.php b/tests/phpunit/includes/libs/XhprofTest.php index 6748115..c9123b8 100644 --- a/tests/phpunit/includes/libs/XhprofTest.php +++ b/tests/phpunit/includes/libs/XhprofTest.php @@ -19,6 +19,9 @@ */ class XhprofTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** * Trying to enable Xhprof when it is already enabled causes an exception * to be thrown. diff --git a/tests/phpunit/includes/libs/XmlTypeCheckTest.php b/tests/phpunit/includes/libs/XmlTypeCheckTest.php index 5c5eeaa..97aeec3 100644 --- a/tests/phpunit/includes/libs/XmlTypeCheckTest.php +++ b/tests/phpunit/includes/libs/XmlTypeCheckTest.php @@ -6,6 +6,9 @@ * @covers XMLTypeCheck */ class XmlTypeCheckTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + const WELL_FORMED_XML = "<root><child /></root>"; const MAL_FORMED_XML = "<root><child /></error>"; // @codingStandardsIgnoreStart Generic.Files.LineLength diff --git a/tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php b/tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php index 742eb95..4743710 100644 --- a/tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php +++ b/tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php @@ -4,6 +4,9 @@ * @covers MimeAnalyzer */ class MimeAnalyzerTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** @var MimeAnalyzer */ private $mimeAnalyzer; diff --git a/tests/phpunit/includes/libs/objectcache/CachedBagOStuffTest.php b/tests/phpunit/includes/libs/objectcache/CachedBagOStuffTest.php index 8b9abbc..d71b16c 100644 --- a/tests/phpunit/includes/libs/objectcache/CachedBagOStuffTest.php +++ b/tests/phpunit/includes/libs/objectcache/CachedBagOStuffTest.php @@ -7,6 +7,8 @@ */ class CachedBagOStuffTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @covers CachedBagOStuff::__construct * @covers CachedBagOStuff::doGet diff --git a/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php b/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php index 53d27c0..9eb3409 100644 --- a/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php +++ b/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php @@ -7,6 +7,8 @@ */ class HashBagOStuffTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @covers HashBagOStuff::__construct */ diff --git a/tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php b/tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php index e534f92..7053fc1 100644 --- a/tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php +++ b/tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php @@ -17,6 +17,9 @@ * @covers WANObjectCache::setInterimValue */ class WANObjectCacheTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** @var TimeAdjustableWANObjectCache */ private $cache; /** @var BagOStuff */ diff --git a/tests/phpunit/includes/libs/rdbms/TransactionProfilerTest.php b/tests/phpunit/includes/libs/rdbms/TransactionProfilerTest.php index b6ea426..a0de408 100644 --- a/tests/phpunit/includes/libs/rdbms/TransactionProfilerTest.php +++ b/tests/phpunit/includes/libs/rdbms/TransactionProfilerTest.php @@ -4,6 +4,9 @@ use Psr\Log\LoggerInterface; class TransactionProfilerTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + public function testAffected() { $logger = $this->getMockBuilder( LoggerInterface::class )->getMock(); $logger->expects( $this->exactly( 3 ) )->method( 'info' ); diff --git a/tests/phpunit/includes/libs/rdbms/database/DatabaseDomainTest.php b/tests/phpunit/includes/libs/rdbms/database/DatabaseDomainTest.php index a8dbdd3..4e5f735 100644 --- a/tests/phpunit/includes/libs/rdbms/database/DatabaseDomainTest.php +++ b/tests/phpunit/includes/libs/rdbms/database/DatabaseDomainTest.php @@ -6,6 +6,9 @@ * @covers Wikimedia\Rdbms\DatabaseDomain */ class DatabaseDomainTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + public static function provideConstruct() { return [ 'All strings' => diff --git a/tests/phpunit/includes/libs/rdbms/database/DatabaseMysqlBaseTest.php b/tests/phpunit/includes/libs/rdbms/database/DatabaseMysqlBaseTest.php index 461ef09..a9f1880 100644 --- a/tests/phpunit/includes/libs/rdbms/database/DatabaseMysqlBaseTest.php +++ b/tests/phpunit/includes/libs/rdbms/database/DatabaseMysqlBaseTest.php @@ -106,6 +106,9 @@ } class DatabaseMysqlBaseTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** * @dataProvider provideDiapers * @covers Wikimedia\Rdbms\DatabaseMysqlBase::addIdentifierQuotes diff --git a/tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php b/tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php index 7b84117..10dbcce 100644 --- a/tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php +++ b/tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php @@ -7,6 +7,9 @@ * with creating SQL text. */ class DatabaseSQLTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** @var DatabaseTestHelper */ private $database; diff --git a/tests/phpunit/includes/libs/rdbms/database/DatabaseTest.php b/tests/phpunit/includes/libs/rdbms/database/DatabaseTest.php index 7933f19..4a0a7e7 100644 --- a/tests/phpunit/includes/libs/rdbms/database/DatabaseTest.php +++ b/tests/phpunit/includes/libs/rdbms/database/DatabaseTest.php @@ -7,6 +7,8 @@ class DatabaseTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + protected function setUp() { $this->db = new DatabaseTestHelper( __CLASS__ . '::' . $this->getName() ); } diff --git a/tests/phpunit/includes/libs/xmp/XMPTest.php b/tests/phpunit/includes/libs/xmp/XMPTest.php index 514e6cd..7becad2 100644 --- a/tests/phpunit/includes/libs/xmp/XMPTest.php +++ b/tests/phpunit/includes/libs/xmp/XMPTest.php @@ -6,6 +6,8 @@ */ class XMPTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + protected function setUp() { parent::setUp(); # Requires libxml to do XMP parsing diff --git a/tests/phpunit/includes/libs/xmp/XMPValidateTest.php b/tests/phpunit/includes/libs/xmp/XMPValidateTest.php index 7f7ea93..0785920 100644 --- a/tests/phpunit/includes/libs/xmp/XMPValidateTest.php +++ b/tests/phpunit/includes/libs/xmp/XMPValidateTest.php @@ -7,6 +7,8 @@ */ class XMPValidateTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @dataProvider provideDates * @covers XMPValidate::validateDate diff --git a/tests/phpunit/includes/objectcache/RedisBagOStuffTest.php b/tests/phpunit/includes/objectcache/RedisBagOStuffTest.php index 34a72ce..ea58e4a 100644 --- a/tests/phpunit/includes/objectcache/RedisBagOStuffTest.php +++ b/tests/phpunit/includes/objectcache/RedisBagOStuffTest.php @@ -6,6 +6,9 @@ * @group BagOStuff */ class RedisBagOStuffTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** @var RedisBagOStuff */ private $cache; diff --git a/tests/phpunit/includes/parser/ParserIntegrationTest.php b/tests/phpunit/includes/parser/ParserIntegrationTest.php index c920982..8d17d21 100644 --- a/tests/phpunit/includes/parser/ParserIntegrationTest.php +++ b/tests/phpunit/includes/parser/ParserIntegrationTest.php @@ -15,6 +15,9 @@ * @todo covers tags */ class ParserIntegrationTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** @var array */ private $ptTest; diff --git a/tests/phpunit/includes/registration/VersionCheckerTest.php b/tests/phpunit/includes/registration/VersionCheckerTest.php index 9ee5881..15d0c2b 100644 --- a/tests/phpunit/includes/registration/VersionCheckerTest.php +++ b/tests/phpunit/includes/registration/VersionCheckerTest.php @@ -4,6 +4,9 @@ * @covers VersionChecker */ class VersionCheckerTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** * @dataProvider provideCheck */ diff --git a/tests/phpunit/includes/resourceloader/DerivativeResourceLoaderContextTest.php b/tests/phpunit/includes/resourceloader/DerivativeResourceLoaderContextTest.php index 0be04ef..db1fb64 100644 --- a/tests/phpunit/includes/resourceloader/DerivativeResourceLoaderContextTest.php +++ b/tests/phpunit/includes/resourceloader/DerivativeResourceLoaderContextTest.php @@ -6,6 +6,8 @@ */ class DerivativeResourceLoaderContextTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + protected static function getContext() { $request = new FauxRequest( [ 'lang' => 'zh', diff --git a/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php b/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php index 1f2c617..7521e88 100644 --- a/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php +++ b/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php @@ -8,6 +8,8 @@ */ class MessageBlobStoreTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + protected function setUp() { parent::setUp(); // MediaWiki tests defaults $wgMainWANCache to CACHE_NONE. diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderClientHtmlTest.php b/tests/phpunit/includes/resourceloader/ResourceLoaderClientHtmlTest.php index f75d67d..49aeb30 100644 --- a/tests/phpunit/includes/resourceloader/ResourceLoaderClientHtmlTest.php +++ b/tests/phpunit/includes/resourceloader/ResourceLoaderClientHtmlTest.php @@ -7,6 +7,8 @@ */ class ResourceLoaderClientHtmlTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + protected static function expandVariables( $text ) { return strtr( $text, [ '{blankVer}' => ResourceLoaderTestCase::BLANK_VERSION diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderContextTest.php b/tests/phpunit/includes/resourceloader/ResourceLoaderContextTest.php index b658efb..f848556 100644 --- a/tests/phpunit/includes/resourceloader/ResourceLoaderContextTest.php +++ b/tests/phpunit/includes/resourceloader/ResourceLoaderContextTest.php @@ -9,6 +9,9 @@ * @covers ResourceLoaderContext */ class ResourceLoaderContextTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + protected static function getResourceLoader() { return new EmptyResourceLoader( new HashConfig( [ 'ResourceLoaderDebug' => false, diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderSkinModuleTest.php b/tests/phpunit/includes/resourceloader/ResourceLoaderSkinModuleTest.php index be17a69..6b0095c 100644 --- a/tests/phpunit/includes/resourceloader/ResourceLoaderSkinModuleTest.php +++ b/tests/phpunit/includes/resourceloader/ResourceLoaderSkinModuleTest.php @@ -5,6 +5,8 @@ */ class ResourceLoaderSkinModuleTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + // @codingStandardsIgnoreStart Ignore Generic.Files.LineLength.TooLong public static function provideGetStyles() { return [ diff --git a/tests/phpunit/includes/services/ServiceContainerTest.php b/tests/phpunit/includes/services/ServiceContainerTest.php index b68ee48..f4f5650 100644 --- a/tests/phpunit/includes/services/ServiceContainerTest.php +++ b/tests/phpunit/includes/services/ServiceContainerTest.php @@ -8,6 +8,8 @@ */ class ServiceContainerTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + private function newServiceContainer( $extraArgs = [] ) { return new ServiceContainer( $extraArgs ); } diff --git a/tests/phpunit/includes/shell/CommandFactoryTest.php b/tests/phpunit/includes/shell/CommandFactoryTest.php index bf0f65b..cb2669f 100644 --- a/tests/phpunit/includes/shell/CommandFactoryTest.php +++ b/tests/phpunit/includes/shell/CommandFactoryTest.php @@ -10,6 +10,9 @@ * @group Shell */ class CommandFactoryTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + /** * @covers MediaWiki\Shell\CommandFactory::create */ diff --git a/tests/phpunit/includes/shell/CommandTest.php b/tests/phpunit/includes/shell/CommandTest.php index 385dd50..2bafa03 100644 --- a/tests/phpunit/includes/shell/CommandTest.php +++ b/tests/phpunit/includes/shell/CommandTest.php @@ -8,6 +8,9 @@ * @group Shell */ class CommandTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + private function requirePosix() { if ( wfIsWindows() ) { $this->markTestSkipped( 'This test requires a POSIX environment.' ); diff --git a/tests/phpunit/includes/shell/FirejailCommandTest.php b/tests/phpunit/includes/shell/FirejailCommandTest.php index 7d6d7f8..02e6e79 100644 --- a/tests/phpunit/includes/shell/FirejailCommandTest.php +++ b/tests/phpunit/includes/shell/FirejailCommandTest.php @@ -24,6 +24,9 @@ use Wikimedia\TestingAccessWrapper; class FirejailCommandTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + public function provideBuildFinalCommand() { global $IP; // @codingStandardsIgnoreStart diff --git a/tests/phpunit/includes/shell/ShellTest.php b/tests/phpunit/includes/shell/ShellTest.php index 2f68dbd..986a665 100644 --- a/tests/phpunit/includes/shell/ShellTest.php +++ b/tests/phpunit/includes/shell/ShellTest.php @@ -7,6 +7,9 @@ * @group Shell */ class ShellTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + public function testIsDisabled() { $this->assertInternalType( 'bool', Shell::isDisabled() ); // sanity } diff --git a/tests/phpunit/includes/site/FileBasedSiteLookupTest.php b/tests/phpunit/includes/site/FileBasedSiteLookupTest.php index 7984795..ed6fbfe 100644 --- a/tests/phpunit/includes/site/FileBasedSiteLookupTest.php +++ b/tests/phpunit/includes/site/FileBasedSiteLookupTest.php @@ -29,6 +29,8 @@ */ class FileBasedSiteLookupTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + protected function setUp() { $this->cacheFile = $this->getCacheFile(); } diff --git a/tests/phpunit/includes/site/MediaWikiPageNameNormalizerTest.php b/tests/phpunit/includes/site/MediaWikiPageNameNormalizerTest.php index 64cdbaa..d230550 100644 --- a/tests/phpunit/includes/site/MediaWikiPageNameNormalizerTest.php +++ b/tests/phpunit/includes/site/MediaWikiPageNameNormalizerTest.php @@ -29,6 +29,8 @@ */ class MediaWikiPageNameNormalizerTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @dataProvider normalizePageTitleProvider */ diff --git a/tests/phpunit/includes/site/SiteExporterTest.php b/tests/phpunit/includes/site/SiteExporterTest.php index c0d8c00..09cdea7 100644 --- a/tests/phpunit/includes/site/SiteExporterTest.php +++ b/tests/phpunit/includes/site/SiteExporterTest.php @@ -31,6 +31,8 @@ */ class SiteExporterTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + public function testConstructor_InvalidArgument() { $this->setExpectedException( 'InvalidArgumentException' ); diff --git a/tests/phpunit/includes/site/SiteImporterTest.php b/tests/phpunit/includes/site/SiteImporterTest.php index ea49429..8a43bf8 100644 --- a/tests/phpunit/includes/site/SiteImporterTest.php +++ b/tests/phpunit/includes/site/SiteImporterTest.php @@ -31,6 +31,8 @@ */ class SiteImporterTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + private function newSiteImporter( array $expectedSites, $errorCount ) { $store = $this->getMockBuilder( 'SiteStore' )->getMock(); diff --git a/tests/phpunit/includes/site/SitesCacheFileBuilderTest.php b/tests/phpunit/includes/site/SitesCacheFileBuilderTest.php index af94a9d..6514beb 100644 --- a/tests/phpunit/includes/site/SitesCacheFileBuilderTest.php +++ b/tests/phpunit/includes/site/SitesCacheFileBuilderTest.php @@ -29,6 +29,8 @@ */ class SitesCacheFileBuilderTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + protected function setUp() { $this->cacheFile = $this->getCacheFile(); } diff --git a/tests/phpunit/includes/utils/AvroValidatorTest.php b/tests/phpunit/includes/utils/AvroValidatorTest.php index 7559e22..902f6d9 100644 --- a/tests/phpunit/includes/utils/AvroValidatorTest.php +++ b/tests/phpunit/includes/utils/AvroValidatorTest.php @@ -10,6 +10,9 @@ */ class AvroValidatorTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + public function setUp() { if ( !class_exists( 'AvroSchema' ) ) { $this->markTestSkipped( 'Avro is required to run the AvroValidatorTest' ); diff --git a/tests/phpunit/includes/utils/ClassCollectorTest.php b/tests/phpunit/includes/utils/ClassCollectorTest.php index e8a228e..8e07b5e 100644 --- a/tests/phpunit/includes/utils/ClassCollectorTest.php +++ b/tests/phpunit/includes/utils/ClassCollectorTest.php @@ -5,6 +5,8 @@ */ class ClassCollectorTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + public static function provideCases() { return [ [ diff --git a/tests/phpunit/includes/utils/FileContentsHasherTest.php b/tests/phpunit/includes/utils/FileContentsHasherTest.php index 0ee4c13..b3885bd 100644 --- a/tests/phpunit/includes/utils/FileContentsHasherTest.php +++ b/tests/phpunit/includes/utils/FileContentsHasherTest.php @@ -5,6 +5,8 @@ */ class FileContentsHasherTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + public function provideSingleFile() { return array_map( function ( $file ) { return [ $file, file_get_contents( $file ) ]; diff --git a/tests/phpunit/includes/utils/MWCryptHashTest.php b/tests/phpunit/includes/utils/MWCryptHashTest.php index 905d14c..13151ab 100644 --- a/tests/phpunit/includes/utils/MWCryptHashTest.php +++ b/tests/phpunit/includes/utils/MWCryptHashTest.php @@ -6,6 +6,8 @@ class MWCryptHashTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + public function testHashLength() { if ( MWCryptHash::hashAlgo() !== 'whirlpool' ) { $this->markTestSkipped( 'Hash algorithm isn\'t whirlpool' ); diff --git a/tests/phpunit/includes/utils/MWRestrictionsTest.php b/tests/phpunit/includes/utils/MWRestrictionsTest.php index f2ea489..4c05326 100644 --- a/tests/phpunit/includes/utils/MWRestrictionsTest.php +++ b/tests/phpunit/includes/utils/MWRestrictionsTest.php @@ -1,6 +1,8 @@ <?php class MWRestrictionsTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + protected static $restrictionsForChecks; public static function setUpBeforeClass() { diff --git a/tests/phpunit/includes/utils/UIDGeneratorTest.php b/tests/phpunit/includes/utils/UIDGeneratorTest.php index 8b54b72..230c935 100644 --- a/tests/phpunit/includes/utils/UIDGeneratorTest.php +++ b/tests/phpunit/includes/utils/UIDGeneratorTest.php @@ -2,6 +2,8 @@ class UIDGeneratorTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + protected function tearDown() { // Bug: 44850 UIDGenerator::unitTestTearDown(); diff --git a/tests/phpunit/includes/utils/ZipDirectoryReaderTest.php b/tests/phpunit/includes/utils/ZipDirectoryReaderTest.php index 7e74d96..09a0676 100644 --- a/tests/phpunit/includes/utils/ZipDirectoryReaderTest.php +++ b/tests/phpunit/includes/utils/ZipDirectoryReaderTest.php @@ -5,6 +5,9 @@ * NOTE: this test is more like an integration test than a unit test */ class ZipDirectoryReaderTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + protected $zipDir; protected $entries; diff --git a/tests/phpunit/includes/watcheditem/WatchedItemQueryServiceUnitTest.php b/tests/phpunit/includes/watcheditem/WatchedItemQueryServiceUnitTest.php index 62ba5f6..ef2486d 100644 --- a/tests/phpunit/includes/watcheditem/WatchedItemQueryServiceUnitTest.php +++ b/tests/phpunit/includes/watcheditem/WatchedItemQueryServiceUnitTest.php @@ -8,6 +8,8 @@ */ class WatchedItemQueryServiceUnitTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @return PHPUnit_Framework_MockObject_MockObject|Database */ diff --git a/tests/phpunit/languages/LanguageCodeTest.php b/tests/phpunit/languages/LanguageCodeTest.php index 950d2df..d36f38b 100644 --- a/tests/phpunit/languages/LanguageCodeTest.php +++ b/tests/phpunit/languages/LanguageCodeTest.php @@ -10,6 +10,8 @@ */ class LanguageCodeTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + public function testConstructor() { $instance = new LanguageCode(); diff --git a/tests/phpunit/maintenance/BenchmarkerTest.php b/tests/phpunit/maintenance/BenchmarkerTest.php index 69f98bd..ec570e2 100644 --- a/tests/phpunit/maintenance/BenchmarkerTest.php +++ b/tests/phpunit/maintenance/BenchmarkerTest.php @@ -6,6 +6,9 @@ * @covers Benchmarker */ class BenchmarkerTest extends PHPUnit_Framework_TestCase { + + use MediaWikiCoversValidator; + public function testBenchSimple() { $bench = $this->getMockBuilder( Benchmarker::class ) ->setMethods( [ 'execute', 'output' ] ) diff --git a/tests/phpunit/structure/AvailableRightsTest.php b/tests/phpunit/structure/AvailableRightsTest.php index 16a9a24..4ab0c2c 100644 --- a/tests/phpunit/structure/AvailableRightsTest.php +++ b/tests/phpunit/structure/AvailableRightsTest.php @@ -8,6 +8,8 @@ */ class AvailableRightsTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * Returns all rights that should be in $wgAvailableRights + all rights * registered via the 'UserGetAllRights' hook + all "core" rights. diff --git a/tests/phpunit/structure/ExtensionJsonValidationTest.php b/tests/phpunit/structure/ExtensionJsonValidationTest.php index b19376d..0cf4659 100644 --- a/tests/phpunit/structure/ExtensionJsonValidationTest.php +++ b/tests/phpunit/structure/ExtensionJsonValidationTest.php @@ -22,6 +22,8 @@ */ class ExtensionJsonValidationTest extends PHPUnit_Framework_TestCase { + use MediaWikiCoversValidator; + /** * @var ExtensionJsonValidator */ -- To view, visit https://gerrit.wikimedia.org/r/400748 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c4de7e9c72c9969088666007b54c6fd23f6cc13 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: C. Scott Ananian <canan...@wikimedia.org> Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: TTO <at.li...@live.com.au> Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits