Phantom42 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401495 )
Change subject: Fix incorrect subscriber count updates
......................................................................
Fix incorrect subscriber count updates
`NewsletterDb::addSubscription` and `NewsletterDb::removeSubscription`
updated subscribers count incorrectly. Subscriber count was increased
or decreased by 1 even if more than 1 subscribers were added or removed.
Bug: T183912
Change-Id: I413ee3d9bca3b5b20982f460621071027f399415
---
M includes/NewsletterDb.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/95/401495/1
diff --git a/includes/NewsletterDb.php b/includes/NewsletterDb.php
index 46d40bc..d60172b 100644
--- a/includes/NewsletterDb.php
+++ b/includes/NewsletterDb.php
@@ -42,7 +42,7 @@
$dbw->update(
'nl_newsletters',
// For index reasons, count is negative
- [ 'nl_subscriber_count=nl_subscriber_count-1' ],
+ [ 'nl_subscriber_count=nl_subscriber_count-' .
count( $userIds ) ],
[ 'nl_id' => $newsletter->getId() ],
__METHOD__
);
@@ -74,7 +74,7 @@
$dbw->update(
'nl_newsletters',
// For index reasons, count is negative
- [ 'nl_subscriber_count=nl_subscriber_count+1' ],
+ [ 'nl_subscriber_count=nl_subscriber_count+' .
count( $userIds ) ],
[ 'nl_id' => $newsletter->getId() ],
__METHOD__
);
--
To view, visit https://gerrit.wikimedia.org/r/401495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I413ee3d9bca3b5b20982f460621071027f399415
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Phantom42 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
