jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/401494 )
Change subject: Rewrote is section collapsed tests in StatementHtmlGeneratorTest
......................................................................
Rewrote is section collapsed tests in StatementHtmlGeneratorTest
Change-Id: I2585d6c244b4a2a76b2bb1134fa1b3b0e5137b22
---
M view/tests/phpunit/StatementHtmlGeneratorTest.php
1 file changed, 22 insertions(+), 19 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/view/tests/phpunit/StatementHtmlGeneratorTest.php
b/view/tests/phpunit/StatementHtmlGeneratorTest.php
index d928706..b0b4930 100644
--- a/view/tests/phpunit/StatementHtmlGeneratorTest.php
+++ b/view/tests/phpunit/StatementHtmlGeneratorTest.php
@@ -114,10 +114,7 @@
return $testCases;
}
- /**
- * @dataProvider referencesProvider
- */
- public function testCollapsedReferences( Statement $statement,
$expected ) {
+ public function testGivenNoReferences_SectionIsNotCollapsed() {
$templateFactory = TemplateFactory::getDefaultInstance();
$statementHtmlGenerator = new StatementHtmlGenerator(
$templateFactory,
@@ -126,24 +123,30 @@
new DummyLocalizedTextProvider()
);
- $html = $statementHtmlGenerator->getHtmlForStatement(
$statement, '' );
-
- $this->assertSame(
- $expected ? 1 : 0,
- substr_count( $html, 'wikibase-initially-collapsed' )
- );
- }
-
- public function referencesProvider() {
$snak = new PropertyNoValueSnak( 1 );
$statement = new Statement( $snak );
- $referencedStatement = clone $statement;
- $referencedStatement->addNewReference( $snak );
- return [
- [ $statement, false ],
- [ $referencedStatement, true ],
- ];
+ $html = $statementHtmlGenerator->getHtmlForStatement(
$statement, '<EDIT SECTION HTML>' );
+
+ $this->assertNotContains( 'wikibase-initially-collapsed', $html
);
+ }
+
+ public function testGivenReferencedStatement_SectionIsCollapsed() {
+ $templateFactory = TemplateFactory::getDefaultInstance();
+ $statementHtmlGenerator = new StatementHtmlGenerator(
+ $templateFactory,
+ $this->getSnakHtmlGeneratorMock(),
+ new BasicNumberLocalizer(),
+ new DummyLocalizedTextProvider()
+ );
+
+ $snak = new PropertyNoValueSnak( 1 );
+ $statement = new Statement( $snak );
+ $statement->addNewReference( $snak );
+
+ $html = $statementHtmlGenerator->getHtmlForStatement(
$statement, '<EDIT SECTION HTML>' );
+
+ $this->assertContains( 'wikibase-initially-collapsed', $html );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/401494
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2585d6c244b4a2a76b2bb1134fa1b3b0e5137b22
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
