Thiemo Kreuz (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401721 )
Change subject: Type hint against IDatabase instead of Database
......................................................................
Type hint against IDatabase instead of Database
Change-Id: I8e2ea8167e7f7f3a41cf321e6387801e1c03c212
---
M src/UpdateTable/Importer/BasicImporter.php
1 file changed, 4 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PropertySuggester
refs/changes/21/401721/1
diff --git a/src/UpdateTable/Importer/BasicImporter.php
b/src/UpdateTable/Importer/BasicImporter.php
index 1baa8e9..2e19435 100644
--- a/src/UpdateTable/Importer/BasicImporter.php
+++ b/src/UpdateTable/Importer/BasicImporter.php
@@ -4,7 +4,7 @@
use UnexpectedValueException;
use PropertySuggester\UpdateTable\ImportContext;
-use Wikimedia\Rdbms\Database;
+use Wikimedia\Rdbms\IDatabase;
/**
* A strategy which imports entries from a CSV file into a DB table. Used as
fallback, when no
@@ -37,12 +37,12 @@
}
/**
- * @param $fileHandle
- * @param Database $db
+ * @param resource $fileHandle
+ * @param IDatabase $db
* @param ImportContext $importContext
* @throws UnexpectedValueException
*/
- private function doImport( $fileHandle, Database $db, ImportContext
$importContext ) {
+ private function doImport( $fileHandle, IDatabase $db, ImportContext
$importContext ) {
$accumulator = [];
$batchSize = $importContext->getBatchSize();
$i = 0;
--
To view, visit https://gerrit.wikimedia.org/r/401721
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e2ea8167e7f7f3a41cf321e6387801e1c03c212
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PropertySuggester
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <thiemo.kr...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
