jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/401739 )
Change subject: Make the tour module depend on ext.guidedTour
......................................................................
Make the tour module depend on ext.guidedTour
Otherwise, JS errors happen because mw.guidedTour doesn't exist:
Uncaught TypeError: Cannot read property 'TourBuilder' of undefined
Change-Id: I41f6abc1fdf6b6f3b7ed6c1203aa6e56f611c153
---
M Hooks.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
KartikMistry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Hooks.php b/Hooks.php
index ce482be..c236a06 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -83,7 +83,8 @@
"flow-guidedtour-optin-find-old-conversations-description",
"flow-guidedtour-optin-feedback",
"flow-guidedtour-optin-feedback-description"
- ]
+ ],
+ 'dependencies' => 'ext.guidedTour',
] );
}
--
To view, visit https://gerrit.wikimedia.org/r/401739
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41f6abc1fdf6b6f3b7ed6c1203aa6e56f611c153
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: KartikMistry <kartik.mis...@gmail.com>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
