Hello Bartosz Dziewoński, Catrope, Divec, jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/401764
to review the following change.
Change subject: Revert "Comment out broken test after Chrome upgrade"
......................................................................
Revert "Comment out broken test after Chrome upgrade"
This reverts commit 8c5e78c7f3d90bb79ef3b462f1629880db639c03.
[Once RelEng fix CI.]
Change-Id: I1c34012e66a20754e298654a876a67d04dee18f9
---
M tests/ce/ve.ce.Surface.test.js
1 file changed, 2 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/64/401764/1
diff --git a/tests/ce/ve.ce.Surface.test.js b/tests/ce/ve.ce.Surface.test.js
index 31e5be7..419ecdd 100644
--- a/tests/ce/ve.ce.Surface.test.js
+++ b/tests/ce/ve.ce.Surface.test.js
@@ -1430,18 +1430,12 @@
'</p>',
expectedText: 'Foo\n\n',
msg: 'RDFa attributes encoded into
data-ve-attributes'
- }
- /*
- // Our CI environment uses either Chrome 57
(mediawiki/extensions/VisualEditor)
- // or Chrome 63 (VisualEditor/VisualEditor), but they
produce different results,
- // so this test will always fail in at least one of
them.
+ },
{
rangeOrSelection: new ve.Range( 0, 61 ),
- expectedText:
'abc\n\nd\n\ne\n\nf\n\ng\n\nhi\nj\n\nk\n\nl\n\nm\n\n', // Chrome 57
- expectedText:
'abc\nd\n\ne\n\nf\n\ng\n\nhi\nj\n\nk\n\nl\n\nm\n\n', // Chrome 63
+ expectedText:
'abc\nd\n\ne\n\nf\n\ng\n\nhi\nj\n\nk\n\nl\n\nm\n\n',
msg: 'Plain text of entire document'
}
- */
];
function testRunner( doc, rangeOrSelection, expectedData,
expectedOriginalRange, expectedBalancedRange, expectedHtml, expectedText, msg )
{
--
To view, visit https://gerrit.wikimedia.org/r/401764
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c34012e66a20754e298654a876a67d04dee18f9
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Divec <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
