Cooltey has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401789 )

Change subject: Fix: Rtl + LtR mixed text issue
......................................................................

Fix: Rtl + LtR mixed text issue

 - Remove RtlAwareTextView styles in view_card_featured_article.xml
 (Also found that the text direction does not show properly when we set 
language to Hebrew)

Bug: T184016
Change-Id: Ibbbdd0daa98c8aefe0d965a20ab7385ac67db96f
---
M app/src/main/res/layout/view_card_featured_article.xml
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/89/401789/1

diff --git a/app/src/main/res/layout/view_card_featured_article.xml 
b/app/src/main/res/layout/view_card_featured_article.xml
index b8c3fb0..4cc119c 100644
--- a/app/src/main/res/layout/view_card_featured_article.xml
+++ b/app/src/main/res/layout/view_card_featured_article.xml
@@ -37,7 +37,6 @@
         android:background="?attr/selectableItemBackground">
 
         <TextView
-            style="@style/RtlAwareTextView"
             android:id="@+id/view_featured_article_card_article_title"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
@@ -52,7 +51,6 @@
             tools:text="Lorem ipsum"/>
 
         <org.wikipedia.views.GoneIfEmptyTextView
-            style="@style/RtlAwareTextView"
             android:id="@+id/view_featured_article_card_article_subtitle"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
@@ -66,7 +64,6 @@
             tools:text="Lorem ipsum"/>
 
         <TextView
-            style="@style/RtlAwareTextView"
             android:id="@+id/view_featured_article_card_extract"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"

-- 
To view, visit https://gerrit.wikimedia.org/r/401789
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbbdd0daa98c8aefe0d965a20ab7385ac67db96f
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Cooltey <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to