DCausse has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402020 )

Change subject: [cleanup] remove BC code check for SearchEngine::getSort
......................................................................

[cleanup] remove BC code check for SearchEngine::getSort

getSort was added in 1.25 and I'm pretty sure CirrusSearch does no longer
support core version 1.24 and lower.

Change-Id: I03cc710f55ae8cda060a54d2fad0bf5487cbf5c7
---
M includes/CirrusSearch.php
1 file changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch 
refs/changes/20/402020/1

diff --git a/includes/CirrusSearch.php b/includes/CirrusSearch.php
index f41c9b3..28384f3 100644
--- a/includes/CirrusSearch.php
+++ b/includes/CirrusSearch.php
@@ -337,12 +337,7 @@
                }
 
                $searcher->getSearchContext()->setLimitSearchToLocalWiki( 
$forceLocal );
-
-               // TODO remove this when we no longer have to support core 
versions without
-               // Ie946150c6796139201221dfa6f7750c210e97166
-               if ( method_exists( $this, 'getSort' ) ) {
-                       $searcher->setSort( $this->getSort() );
-               }
+               $searcher->setSort( $this->getSort() );
 
                if ( isset( 
$this->features[SearchEngine::FT_QUERY_INDEP_PROFILE_TYPE] ) ) {
                        $profile = 
$this->features[SearchEngine::FT_QUERY_INDEP_PROFILE_TYPE];

-- 
To view, visit https://gerrit.wikimedia.org/r/402020
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I03cc710f55ae8cda060a54d2fad0bf5487cbf5c7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: DCausse <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to