BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402083 )
Change subject: News: don't include empty stories ...................................................................... News: don't include empty stories Bug: T184198 Change-Id: Ia2e7c4cc61cbb99e2fa0f5af355ba5cf837f0401 --- M lib/feed/news.js M test/features/news/news.js 2 files changed, 9 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps refs/changes/83/402083/1 diff --git a/lib/feed/news.js b/lib/feed/news.js index eea1715..d81d261 100644 --- a/lib/feed/news.js +++ b/lib/feed/news.js @@ -25,7 +25,11 @@ }); story.story = storyHtml.innerHTML; - return story; + if (story.story.length > 0 && story.links.length > 0) { + return story; + } else { + return undefined; + } } function promise(app, req) { @@ -55,8 +59,10 @@ }; Array.prototype.forEach.call(headlines, (storyHtml) => { - result.payload.push(constructStory(app.restbase_tpl, req.params.domain, lang, - storyHtml)); + const story = constructStory(app.restbase_tpl, req.params.domain, lang, storyHtml); + if (story) { + result.payload.push(story); + } }); return result; diff --git a/test/features/news/news.js b/test/features/news/news.js index d554811..36f9997 100644 --- a/test/features/news/news.js +++ b/test/features/news/news.js @@ -50,10 +50,6 @@ before(() => { return server.start(); }); for (const lang in NEWS_TEMPLATES) { - if (lang === 'fr') { - continue; // TODO: unskip testing french news today - } - if ({}.hasOwnProperty.call(NEWS_TEMPLATES, lang)) { it(`${lang}: should respond with expected headers, incl. CORS and CSP headers`, () => { return checkHeaders(`${server.config.uri}${lang}.wikipedia.org/v1/page/news`, -- To view, visit https://gerrit.wikimedia.org/r/402083 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2e7c4cc61cbb99e2fa0f5af355ba5cf837f0401 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/services/mobileapps Gerrit-Branch: master Gerrit-Owner: BearND <bsitzm...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits