Elukey has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/402084 )
Change subject: role::analytics_cluster: avoid to expicitly instance the standard class ...................................................................... role::analytics_cluster: avoid to expicitly instance the standard class Bug: T167790 Change-Id: Id1c60a0c3feb6b12ac75950702e94c17d3542038 --- M modules/role/manifests/analytics_cluster/hadoop/master.pp M modules/role/manifests/analytics_cluster/hadoop/standby.pp M modules/role/manifests/analytics_cluster/webserver.pp 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Elukey: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/role/manifests/analytics_cluster/hadoop/master.pp b/modules/role/manifests/analytics_cluster/hadoop/master.pp index 8c53b8a..28deec8 100644 --- a/modules/role/manifests/analytics_cluster/hadoop/master.pp +++ b/modules/role/manifests/analytics_cluster/hadoop/master.pp @@ -13,5 +13,5 @@ include ::profile::hadoop::firewall::master include ::profile::hadoop::logstash include ::profile::base::firewall - class { 'standard': } + include standard } diff --git a/modules/role/manifests/analytics_cluster/hadoop/standby.pp b/modules/role/manifests/analytics_cluster/hadoop/standby.pp index 03ac4bc..465ebf6 100644 --- a/modules/role/manifests/analytics_cluster/hadoop/standby.pp +++ b/modules/role/manifests/analytics_cluster/hadoop/standby.pp @@ -24,6 +24,6 @@ include ::profile::analytics::database::meta::backup_dest include ::profile::base::firewall - class { 'standard': } + include standard } diff --git a/modules/role/manifests/analytics_cluster/webserver.pp b/modules/role/manifests/analytics_cluster/webserver.pp index b4d9ffc..3e9f0c8 100644 --- a/modules/role/manifests/analytics_cluster/webserver.pp +++ b/modules/role/manifests/analytics_cluster/webserver.pp @@ -13,5 +13,5 @@ include ::profile::druid::pivot include ::profile::base::firewall - class { 'standard': } + include standard } \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/402084 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1c60a0c3feb6b12ac75950702e94c17d3542038 Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Elukey <ltosc...@wikimedia.org> Gerrit-Reviewer: Elukey <ltosc...@wikimedia.org> Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits