Alexandros Kosiaris has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402101 )
Change subject: ircecho: Force unbuffered stdin/stdout/stderr ...................................................................... ircecho: Force unbuffered stdin/stdout/stderr stdin/stdout/stderr are effectively used by ircecho for debugging/logging messages. However these are not thread safe and ircecho uses threads. The result is usually lost logs that await in the buffer to be flushed and make debugging difficult. Pass -u to python and change from using the env variable since /usr/bin/env can't really handle arguments While the better solution would be to rewrite parts of the software to use the logging module, this is deemed enough for now Change-Id: I9a7b596725bb25be63ea3b6326ab014354ff6575 --- M modules/ircecho/files/ircecho.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/01/402101/1 diff --git a/modules/ircecho/files/ircecho.py b/modules/ircecho/files/ircecho.py index bb06ae6..c7c94ea 100755 --- a/modules/ircecho/files/ircecho.py +++ b/modules/ircecho/files/ircecho.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/python -u # vim: set tabstop=4 shiftwidth=4 softtabstop=4 expandtab textwidth=80 smarttab # # stdin -> IRC echo bot, with optional file input support. -- To view, visit https://gerrit.wikimedia.org/r/402101 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9a7b596725bb25be63ea3b6326ab014354ff6575 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Alexandros Kosiaris <akosia...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
