jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/401722 )
Change subject: Type hint against IDatabase instead of Database
......................................................................
Type hint against IDatabase instead of Database
Change-Id: I4050e1e08fe084cca046f4743d19259f933ea61b
---
M client/tests/phpunit/includes/Store/Sql/PagePropsEntityIdLookupTest.php
M client/tests/phpunit/includes/Usage/Sql/EntityUsageTableTest.php
M repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php
3 files changed, 5 insertions(+), 4 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/client/tests/phpunit/includes/Store/Sql/PagePropsEntityIdLookupTest.php
b/client/tests/phpunit/includes/Store/Sql/PagePropsEntityIdLookupTest.php
index f991e97..1964618 100644
--- a/client/tests/phpunit/includes/Store/Sql/PagePropsEntityIdLookupTest.php
+++ b/client/tests/phpunit/includes/Store/Sql/PagePropsEntityIdLookupTest.php
@@ -7,7 +7,7 @@
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Entity\ItemIdParser;
-use Wikimedia\Rdbms\Database;
+use Wikimedia\Rdbms\IDatabase;
/**
* @covers Wikibase\Client\Store\Sql\PagePropsEntityIdLookup
@@ -34,7 +34,7 @@
return $title;
}
- private function insertPageProps( Database $db, $pageId, EntityId
$entityId ) {
+ private function insertPageProps( IDatabase $db, $pageId, EntityId
$entityId ) {
$db->insert(
'page_props',
[
diff --git a/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableTest.php
b/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableTest.php
index f27d54d..3fb4c9f 100644
--- a/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableTest.php
+++ b/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableTest.php
@@ -347,7 +347,7 @@
}
/**
- * @param Database $db
+ * @param IDatabase $db
* @param array $conditions
*
* @return bool
diff --git
a/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php
b/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php
index 4f2d989..be41a7d 100644
--- a/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php
+++ b/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php
@@ -15,6 +15,7 @@
use Wikibase\Repo\WikibaseRepo;
use Wikimedia\Rdbms\Database;
use Wikimedia\Rdbms\FakeResultWrapper;
+use Wikimedia\Rdbms\IDatabase;
/**
* This test needs to be in repo, although the class is in lib as we can't
alter
@@ -104,7 +105,7 @@
/**
* Gets a "lagged" database connection: We always leave out the first
row on select.
*/
- private function getLaggedDatabase( Database $realDB, $selectCount,
$selectRowCount ) {
+ private function getLaggedDatabase( IDatabase $realDB, $selectCount,
$selectRowCount ) {
$db = $this->getMockBuilder( Database::class )
->disableOriginalConstructor()
->setMethods( [ 'select', 'selectRow' ] )
--
To view, visit https://gerrit.wikimedia.org/r/401722
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4050e1e08fe084cca046f4743d19259f933ea61b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <thiemo.kr...@wikimedia.de>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Thiemo Kreuz (WMDE) <thiemo.kr...@wikimedia.de>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
