Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402125 )
Change subject: Type hint against IDatabase instead of Database
......................................................................
Type hint against IDatabase instead of Database
Change-Id: Ibb0e3fd3531ce5f115933a5fc33e2e08892b5186
---
M includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityExternalValidation
refs/changes/25/402125/1
diff --git a/includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php
b/includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php
index 9c1be85..355c250 100644
--- a/includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php
+++ b/includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php
@@ -2,12 +2,12 @@
namespace WikibaseQuality\ExternalValidation\DumpMetaInformation;
-use Database;
use InvalidArgumentException;
use UnexpectedValueException;
use ResultWrapper;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Entity\PropertyId;
+use Wikimedia\Rdbms\IDatabase;
/**
* Implements access to the actual database table that stores the dump
information.
@@ -229,11 +229,11 @@
}
/**
- * @param Database $db
+ * @param IDatabase $db
* @param DumpMetaInformation $dumpMetaInformation
* @return array
*/
- private function getDumpInformationFields( Database $db,
DumpMetaInformation $dumpMetaInformation ) {
+ private function getDumpInformationFields( IDatabase $db,
DumpMetaInformation $dumpMetaInformation ) {
return [
'id' => $dumpMetaInformation->getDumpId(),
'source_qid' =>
$dumpMetaInformation->getSourceItemId()->getSerialization(),
--
To view, visit https://gerrit.wikimedia.org/r/402125
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb0e3fd3531ce5f115933a5fc33e2e08892b5186
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
