MaxSem has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402139 )
Change subject: Remove TODOs we decided we don't need
......................................................................
Remove TODOs we decided we don't need
Bug: T175978
Change-Id: I9b1bdb91229a086bebec3865c096f2c7e8492bac
---
M includes/SpecialGlobalPreferences.php
1 file changed, 0 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalPreferences
refs/changes/39/402139/1
diff --git a/includes/SpecialGlobalPreferences.php
b/includes/SpecialGlobalPreferences.php
index 9cc3d6b..fc0d235 100644
--- a/includes/SpecialGlobalPreferences.php
+++ b/includes/SpecialGlobalPreferences.php
@@ -80,7 +80,6 @@
* @throws PermissionsError
*/
protected function showGlobalPrefsResetForm() {
- // TODO: Should we have our own userright here?
if ( !$this->getUser()->isAllowed( 'editmyoptions' ) ) {
throw new PermissionsError( 'editmyoptions' );
}
@@ -125,7 +124,6 @@
* @throws PermissionsError
*/
public function submitReset( $formData ) {
- // TODO: Should we have our own userright here?
if ( !$this->getUser()->isAllowed( 'editmyoptions' ) ) {
throw new PermissionsError( 'editmyoptions' );
}
--
To view, visit https://gerrit.wikimedia.org/r/402139
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b1bdb91229a086bebec3865c096f2c7e8492bac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalPreferences
Gerrit-Branch: master
Gerrit-Owner: MaxSem <maxsem.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
