Thiemo Kreuz (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402586 )
Change subject: Remove obsolete text from self-explaining code
......................................................................
Remove obsolete text from self-explaining code
Change-Id: I6a29891383a6d76b26d566b980f6253d1ec0bf44
---
M Hooks.php
M includes/Conversion/Utils.php
M includes/Data/Listener/RecentChangesListener.php
M includes/Notifications/Controller.php
M includes/Notifications/FlowPresentationModel.php
M includes/OOUI/BoardDescriptionWidget.php
6 files changed, 8 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/86/402586/1
diff --git a/Hooks.php b/Hooks.php
index ec52bfd..4c13761 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -180,7 +180,7 @@
/**
* Hook: LoadExtensionSchemaUpdates
*
- * @param DatabaseUpdater $updater DatabaseUpdater object
+ * @param DatabaseUpdater $updater
* @return bool true in all cases
*/
public static function getSchemaUpdates( DatabaseUpdater $updater ) {
@@ -1132,7 +1132,7 @@
/**
* Add topiclist sortby to preferences.
*
- * @param User $user User object
+ * @param User $user
* @param array &$preferences Preferences object
* @return bool
*/
diff --git a/includes/Conversion/Utils.php b/includes/Conversion/Utils.php
index 528065e..232544c 100644
--- a/includes/Conversion/Utils.php
+++ b/includes/Conversion/Utils.php
@@ -407,7 +407,7 @@
* Handler for FlowAddModules, avoids rest of Flow having to be aware if
* Parsoid is in use.
*
- * @param OutputPage $out OutputPage object
+ * @param OutputPage $out
* @return bool
*/
public static function onFlowAddModules( OutputPage $out ) {
diff --git a/includes/Data/Listener/RecentChangesListener.php
b/includes/Data/Listener/RecentChangesListener.php
index cfe173a..6edc98e 100644
--- a/includes/Data/Listener/RecentChangesListener.php
+++ b/includes/Data/Listener/RecentChangesListener.php
@@ -41,7 +41,7 @@
/**
* @param FlowActions $actions
* @param UserNameBatch $usernames
- * @param RecentChangeFactory $rcFactory Creates mw RecentChange
instances
+ * @param RecentChangeFactory $rcFactory
* @param IRCLineUrlFormatter $ircFormatter
*/
public function __construct(
@@ -57,7 +57,7 @@
}
/**
- * @param AbstractRevision $revision Revision object
+ * @param AbstractRevision $revision
* @param array $row Revision row
* @param array $metadata
*/
diff --git a/includes/Notifications/Controller.php
b/includes/Notifications/Controller.php
index c65dac9..bb0a7bb 100644
--- a/includes/Notifications/Controller.php
+++ b/includes/Notifications/Controller.php
@@ -492,7 +492,7 @@
/**
* @param AbstractRevision $content The (post|topic|header) revision
that contains the content of the mention
* @param PostRevision|null $topic Topic PostRevision object, if
relevant (e.g. not for Header)
- * @param Workflow $workflow Workflow object
+ * @param Workflow $workflow
* @param User $user User who created the new post
* @param array $mentionedUsers
* @param bool $mentionsSkipped Were mentions skipped due to too many
mentions being attempted?
diff --git a/includes/Notifications/FlowPresentationModel.php
b/includes/Notifications/FlowPresentationModel.php
index 67d31db..0258b60 100644
--- a/includes/Notifications/FlowPresentationModel.php
+++ b/includes/Notifications/FlowPresentationModel.php
@@ -76,8 +76,8 @@
/**
* Get the topic title Title
*
- * @param string $fragment Optional fragment
- * @return Title Topic title
+ * @param string $fragment
+ * @return Title
*/
protected function getTopicTitleObj( $fragment = '' ) {
$workflowId = $this->event->getExtraParam( 'topic-workflow' );
diff --git a/includes/OOUI/BoardDescriptionWidget.php
b/includes/OOUI/BoardDescriptionWidget.php
index e80ceb0..1bc546d 100644
--- a/includes/OOUI/BoardDescriptionWidget.php
+++ b/includes/OOUI/BoardDescriptionWidget.php
@@ -9,7 +9,6 @@
protected $description = '';
public function __construct( array $config = [] ) {
- // Parent constructor
parent::__construct( $config );
if ( isset( $config['description'] ) ) {
@@ -20,7 +19,6 @@
$editLink = $config['editLink'];
}
- // Edit button
$this->editButton = new \OOUI\ButtonWidget( [
'framed' => false,
'href' => $editLink,
--
To view, visit https://gerrit.wikimedia.org/r/402586
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a29891383a6d76b26d566b980f6253d1ec0bf44
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
