Lucas Werkmeister (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402808 )
Change subject: Add type hint to array|null parameter
......................................................................
Add type hint to array|null parameter
I removed the type hint for this parameter in commit a4c1832358 (change
I60ad838dda) when it was made nullable because I didn’t know that PHP
lets you declare a default argument (which makes the parameter nullable)
even when there are later parameters without default arguments.
Change-Id: I9a3645b51a0fbfb39b6b7c20393f56ba058e8525
---
M src/ConstraintCheck/Context/ApiV2Context.php
M src/ConstraintCheck/Context/Context.php
M tests/phpunit/Fake/FakeSnakContext.php
3 files changed, 3 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
refs/changes/08/402808/1
diff --git a/src/ConstraintCheck/Context/ApiV2Context.php
b/src/ConstraintCheck/Context/ApiV2Context.php
index b693b10..e74613e 100644
--- a/src/ConstraintCheck/Context/ApiV2Context.php
+++ b/src/ConstraintCheck/Context/ApiV2Context.php
@@ -75,7 +75,7 @@
*/
abstract protected function &getMainArray( array &$container );
- public function storeCheckResultInArray( $result, array &$container ) {
+ public function storeCheckResultInArray( array $result = null, array
&$container ) {
$mainArray = &$this->getMainArray( $container );
if ( !array_key_exists( 'results', $mainArray ) ) {
$mainArray['results'] = [];
diff --git a/src/ConstraintCheck/Context/Context.php
b/src/ConstraintCheck/Context/Context.php
index 844bc8b..b09bfe9 100644
--- a/src/ConstraintCheck/Context/Context.php
+++ b/src/ConstraintCheck/Context/Context.php
@@ -86,6 +86,6 @@
* @param array|null $result
* @param array &$container
*/
- public function storeCheckResultInArray( $result, array &$container );
+ public function storeCheckResultInArray( array $result = null, array
&$container );
}
diff --git a/tests/phpunit/Fake/FakeSnakContext.php
b/tests/phpunit/Fake/FakeSnakContext.php
index c51f11e..632c8b3 100644
--- a/tests/phpunit/Fake/FakeSnakContext.php
+++ b/tests/phpunit/Fake/FakeSnakContext.php
@@ -32,7 +32,7 @@
return 'statement';
}
- public function storeCheckResultInArray( $result, array &$container ) {
+ public function storeCheckResultInArray( array $result = null, array
&$container ) {
if ( $result !== null ) {
$container[] = $result;
}
--
To view, visit https://gerrit.wikimedia.org/r/402808
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a3645b51a0fbfb39b6b7c20393f56ba058e8525
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
