Eflyjason has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402814 )

Change subject: Fix document.activeElement when focusing on textarea on mobile 
devices
......................................................................

Fix document.activeElement when focusing on textarea on mobile devices

Bug: T184419
Change-Id: Ic3768280adbe98f0774b9b74300e94598b68cf46
---
M wikibase/queryService/ui/App.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui 
refs/changes/14/402814/1

diff --git a/wikibase/queryService/ui/App.js b/wikibase/queryService/ui/App.js
index 6a7dcb8..ed46f2b 100644
--- a/wikibase/queryService/ui/App.js
+++ b/wikibase/queryService/ui/App.js
@@ -175,7 +175,8 @@
                        return false;
                }
 
-               if ( $( document.activeElement ).is( 'textarea, input' ) ) {
+               if ( $( document.activeElement ).is( 'textarea, input' ) ||
+                       $( document.activeElement ).hasClass( 'CodeMirror-code' 
) ) {
                        if ( e.key === 'Escape' ) {
                                $( document.activeElement ).blur();
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/402814
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3768280adbe98f0774b9b74300e94598b68cf46
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Eflyjason <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to