Thiemo Kreuz (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402852 )

Change subject: Fix broken SiteStore type hint in SitesBuilder
......................................................................

Fix broken SiteStore type hint in SitesBuilder

Reported by Phan.

Luckily this had no effect in production because the SiteLookup we
have is also a SiteStore.

Change-Id: I3cf63fdeaf5b043d7e1914f7b7b180a2d89d417d
---
M lib/includes/Sites/SitesBuilder.php
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/52/402852/1

diff --git a/lib/includes/Sites/SitesBuilder.php 
b/lib/includes/Sites/SitesBuilder.php
index 6dd191d..6975b85 100644
--- a/lib/includes/Sites/SitesBuilder.php
+++ b/lib/includes/Sites/SitesBuilder.php
@@ -3,7 +3,7 @@
 namespace Wikibase\Lib\Sites;
 
 use Site;
-use SiteLookup;
+use SiteStore;
 
 /**
  * Builds the site identifiers table
@@ -16,7 +16,7 @@
 class SitesBuilder {
 
        /**
-        * @var SiteLookup
+        * @var SiteStore
         */
        private $store;
 
@@ -26,10 +26,10 @@
        private $validGroups;
 
        /**
-        * @param SiteLookup $store
+        * @param SiteStore $store
         * @param string[] $validGroups
         */
-       public function __construct( SiteLookup $store, array $validGroups ) {
+       public function __construct( SiteStore $store, array $validGroups ) {
                $this->store = $store;
                $this->validGroups = $validGroups;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/402852
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cf63fdeaf5b043d7e1914f7b7b180a2d89d417d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to