[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[specialpages]: MobileFrontendFeaturesRegistration hook should be called ear...

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403078 )

Change subject: MobileFrontendFeaturesRegistration hook should be called 
earlier in stack
......................................................................

MobileFrontendFeaturesRegistration hook should be called earlier in stack

Bug: T182362
Change-Id: I03839d840d02ed84a850baef1d8625ecdbe6970d
---
M includes/MobileFrontend.hooks.php
1 file changed, 10 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/78/403078/1

diff --git a/includes/MobileFrontend.hooks.php 
b/includes/MobileFrontend.hooks.php
index 6fbb210..a2767c3 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -80,6 +80,15 @@
                        return true;
                }
 
+               // TODO, do we want to have a specific hook just for Mobile 
Features initialization
+               // or do we want to reuse the RequestContextCreateSkinMobile 
and use MediawikiService
+               // to retrieve the FeaturesManager
+               // Important: This must be run before 
RequestContextCreateSkinMobile which may make modifications
+               // to the skin based on enabled features.
+               $featureManager = \MediaWiki\MediaWikiServices::getInstance()
+                       ->getService( 'MobileFrontend.FeaturesManager' );
+               Hooks::run( 'MobileFrontendFeaturesRegistration', [ 
$featureManager ] );
+
                // enable wgUseMediaWikiUIEverywhere
                self::enableMediaWikiUI();
 
@@ -119,15 +128,9 @@
                                return false;
                        }
                }
+
                $skin = self::getDefaultMobileSkin( $context, $mobileContext );
                Hooks::run( 'RequestContextCreateSkinMobile', [ $mobileContext, 
$skin ] );
-
-               // TODO, do we want to have a specific hook just for Mobile 
Features initialization
-               // or do we want to reuse the RequestContextCreateSkinMobile 
and use MediawikiService
-               // to retrieve the FeaturesManager
-               $featureManager = \MediaWiki\MediaWikiServices::getInstance()
-                       ->getService( 'MobileFrontend.FeaturesManager' );
-               Hooks::run( 'MobileFrontendFeaturesRegistration', [ 
$featureManager ] );
 
                return false;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/403078
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I03839d840d02ed84a850baef1d8625ecdbe6970d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: specialpages
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits