jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/394909 )
Change subject: Check for PNG metadata before generating HTML
......................................................................
Check for PNG metadata before generating HTML
When embedding the PNG file(s), the dimensions of the file are
placed into the `<img` tag, being loaded from a metadata file. Only
the existance of the file is checked, and not if it has valid values.
This change adds a check for if the values exist, and if not, to
regenerate the images and metadata.
Bug: T143070
Change-Id: I8dff67269a6cdda555aab33bf0f6c5f4b44c12a4
---
M includes/Score.php
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Score.php b/includes/Score.php
index 7e73548..fba3668 100644
--- a/includes/Score.php
+++ b/includes/Score.php
@@ -378,6 +378,10 @@
!isset( $existingFiles[$imageFileName] )
&& !isset(
$existingFiles[$multi1FileName] )
)
+ || (
+ !isset(
$metaData[$imageFileName]['size'] )
+ && !isset(
$metaData[$multi1FileName]['size'] )
+ )
|| !isset( $existingFiles[$midiFileName] ) ) {
$existingFiles += self::generatePngAndMidi(
$code, $options, $metaData );
}
--
To view, visit https://gerrit.wikimedia.org/r/394909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dff67269a6cdda555aab33bf0f6c5f4b44c12a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Score
Gerrit-Branch: master
Gerrit-Owner: Ebe123 <beauleetien...@gmail.com>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Dereckson <dereck...@espace-win.org>
Gerrit-Reviewer: Ebe123 <beauleetien...@gmail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Matanya <mata...@foss.co.il>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
