Alexandros Kosiaris has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/402344 )
Change subject: ircecho: set EchoNotifier threads as daemon
......................................................................
ircecho: set EchoNotifier threads as daemon
Use the daemon thread notion of python to force closing of the entire
python application when the main thread (the IRC bot) dies. The
EchoNotifier threads are essentially forever loops so waiting to join()
them makes no sense and forcefully killing them makes the code less
portable.
This makes it possible for systemd to restart the application.
Bug: T184103
Change-Id: Ie8446beaee6ec3c39d2eabff5c5b0f809cab4d47
---
M modules/ircecho/files/ircecho.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alexandros Kosiaris: Looks good to me, approved
jenkins-bot: Verified
Volans: Looks good to me, but someone else must approve
diff --git a/modules/ircecho/files/ircecho.py b/modules/ircecho/files/ircecho.py
index eb51012..4147aa1 100755
--- a/modules/ircecho/files/ircecho.py
+++ b/modules/ircecho/files/ircecho.py
@@ -36,6 +36,7 @@
def __init__(self, notifier):
threading.Thread.__init__(self)
self.notifier = notifier
+ self.daemon = True
def run(self):
self.notifier.loop()
--
To view, visit https://gerrit.wikimedia.org/r/402344
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8446beaee6ec3c39d2eabff5c5b0f809cab4d47
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: Alexandros Kosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: Volans <rcocci...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
