Giuseppe Lavagetto has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/359482 )
Change subject: base: fix RuboCop MethodCallWithoutArgsParentheses
......................................................................
base: fix RuboCop MethodCallWithoutArgsParentheses
Fix a service_unit_spec.rb Style/MethodCallWithoutArgsParentheses, and
remove the ignore entirely, as the other two ignores are obsolete.
Change-Id: Ie73f028afe7967a60f4e29fabc4c1a1cc5bf7ff4
---
M .rubocop_todo.yml
M modules/base/spec/defines/service_unit_spec.rb
2 files changed, 1 insertion(+), 7 deletions(-)
Approvals:
Giuseppe Lavagetto: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index c463b8a..c39ac895 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -26,12 +26,6 @@
Layout/IndentationWidth:
Enabled: false
-Style/MethodCallWithoutArgsParentheses:
- Exclude:
- - 'modules/base/spec/defines/service_unit_spec.rb'
- -
'modules/install_server/spec/classes/install_server_preseed_server_spec.rb'
- - 'modules/squid3/spec/classes/squid3_spec.rb'
-
Style/NegatedIf:
Enabled: false
diff --git a/modules/base/spec/defines/service_unit_spec.rb
b/modules/base/spec/defines/service_unit_spec.rb
index 2c79374..3aa3914 100644
--- a/modules/base/spec/defines/service_unit_spec.rb
+++ b/modules/base/spec/defines/service_unit_spec.rb
@@ -43,7 +43,7 @@
it 'should not refresh service' do
expect {
should
contain_file('/etc/init.d/nginx').that_notifies('Service[nginx]')
- }.to raise_error()
+ }.to raise_error
end
end
--
To view, visit https://gerrit.wikimedia.org/r/359482
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie73f028afe7967a60f4e29fabc4c1a1cc5bf7ff4
Gerrit-PatchSet: 5
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <[email protected]>
Gerrit-Reviewer: Gehel <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
