Dbrant has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403182 )
Change subject: Improve fetching of random articles from reading lists.
......................................................................
Improve fetching of random articles from reading lists.
This updates the logic to retrieve random articles from reading lists, so
that only articles that are fully saved are returned, instead of any
article that isn't deleted, which might include articles that are
online-only.
Change-Id: I673b88d774d8731347747cd5562f1dea528328a9
---
M app/src/main/java/org/wikipedia/readinglist/database/ReadingListDbHelper.java
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/82/403182/1
diff --git
a/app/src/main/java/org/wikipedia/readinglist/database/ReadingListDbHelper.java
b/app/src/main/java/org/wikipedia/readinglist/database/ReadingListDbHelper.java
index 3b90199..433443b 100644
---
a/app/src/main/java/org/wikipedia/readinglist/database/ReadingListDbHelper.java
+++
b/app/src/main/java/org/wikipedia/readinglist/database/ReadingListDbHelper.java
@@ -257,8 +257,8 @@
public ReadingListPage getRandomPage() {
SQLiteDatabase db = getReadableDatabase();
try (Cursor cursor = db.query(ReadingListPageContract.TABLE, null,
- ReadingListPageContract.Col.STATUS.getName() + " != ?",
- new
String[]{Integer.toString(ReadingListPage.STATUS_QUEUE_FOR_DELETE)},
+ ReadingListPageContract.Col.STATUS.getName() + " = ?",
+ new String[]{Integer.toString(ReadingListPage.STATUS_SAVED)},
null, null, null)) {
if (cursor.moveToFirst()) {
cursor.move(new Random().nextInt(cursor.getCount()));
--
To view, visit https://gerrit.wikimedia.org/r/403182
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I673b88d774d8731347747cd5562f1dea528328a9
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
