Ejegg has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/327792 )

Change subject: Stop inserting extra 'A/B testing' boards
......................................................................


Stop inserting extra 'A/B testing' boards

Change-Id: Ibb3026cec2a6ce25bc82c8f0a1e5245c5f16d580
---
M schema/0002_abtesting.sql
1 file changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Mepps: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/schema/0002_abtesting.sql b/schema/0002_abtesting.sql
index f632a71..37d3d0a 100644
--- a/schema/0002_abtesting.sql
+++ b/schema/0002_abtesting.sql
@@ -6,13 +6,14 @@
 insert ignore into dash_user (id, display_name)
        value (1, 'Dev User');
 
--- TODO: Make idempotent
+set @board_count = ( select count(*) FROM dash_board WHERE display_name='A/B 
Testing' AND owner_id = 1 );
+
 insert ignore into dash_board (display_name, description, owner_id, is_shared)
-       values ('A/B Testing', 'Banner A/B test results', 1, true);
+       SELECT 'A/B Testing', 'Banner A/B test results', 1, 1
+       FROM dash_user u
+       WHERE id = 1 AND @board_count = 0;
 
-set @bid = (select id from dash_board where display_name = 'A/B Testing');
-
-update dash_user set default_board = @bid where id = 1;
+set @bid = (select id from dash_board where owner_id = 1 AND display_name = 
'A/B Testing');
 
 insert ignore into dash_widget_instance (widget_id, owner_id, display_name, 
is_shared)
        select @wid, 1, display_name, 1 from dash_widget where id = @wid;

-- 
To view, visit https://gerrit.wikimedia.org/r/327792
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb3026cec2a6ce25bc82c8f0a1e5245c5f16d580
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: master
Gerrit-Owner: Ejegg <ej...@ejegg.com>
Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Eileen <emcnaugh...@wikimedia.org>
Gerrit-Reviewer: Ejegg <ej...@ejegg.com>
Gerrit-Reviewer: Katie Horn <kh...@wikimedia.org>
Gerrit-Reviewer: Mepps <me...@wikimedia.org>
Gerrit-Reviewer: XenoRyet <dkozlow...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to