Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403443 )
Change subject: FlaggedRevision, construct Revision with Title if known
......................................................................
FlaggedRevision, construct Revision with Title if known
If we have the Title object we may as well pass it in
to avoid a db call later.
Bug: T184595
Change-Id: Icb3759a98993becba6e7a3090f8a0103d247ce85
(cherry picked from commit 42a2d5967aa35ab86764866de530377e3904cb97)
---
M backend/FlaggedRevision.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/43/403443/1
diff --git a/backend/FlaggedRevision.php b/backend/FlaggedRevision.php
index a536739..e10002b 100644
--- a/backend/FlaggedRevision.php
+++ b/backend/FlaggedRevision.php
@@ -54,8 +54,6 @@
$this->mTags = self::expandRevisionTags( strval(
$row->fr_tags ) );
$this->mFlags = explode( ',', $row->fr_flags );
$this->mUser = intval( $row->fr_user );
- # Base Revision object
- $this->mRevision = new Revision( $row );
# Image page revision relevant params
$this->mFileName = $row->fr_img_name ?
$row->fr_img_name : null;
$this->mFileSha1 = $row->fr_img_sha1 ?
$row->fr_img_sha1 : null;
@@ -65,6 +63,8 @@
$this->mTitle = isset( $row->page_namespace ) && isset(
$row->page_title )
? Title::makeTitleSafe( $row->page_namespace,
$row->page_title )
: null;
+ # Base Revision object
+ $this->mRevision = new Revision( $row,
Revision::READ_NORMAL, $this->mTitle );
} elseif ( is_array( $row ) ) {
$this->mTimestamp = $row['timestamp'];
$this->mQuality = intval( $row['quality'] );
--
To view, visit https://gerrit.wikimedia.org/r/403443
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb3759a98993becba6e7a3090f8a0103d247ce85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: wmf/1.31.0-wmf.16
Gerrit-Owner: Addshore <addshorew...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
