Yaron Koren has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403551 )
Change subject: Fix for 2270fb67891f - remove unset() call
......................................................................
Fix for 2270fb67891f - remove unset() call
It led to an error in certain cases - see T181903.
Bug: T181903
Change-Id: Ia2c07fca66edfb07c2d1ca58394fd07c0f9c766f
---
M includes/SpecialContributors.php
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Yaron Koren: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/SpecialContributors.php b/includes/SpecialContributors.php
index f847ee7..4f36722 100644
--- a/includes/SpecialContributors.php
+++ b/includes/SpecialContributors.php
@@ -32,10 +32,9 @@
$this->setHeaders();
$opts = $this->getOptions();
- $target = $opts['target'];
- unset( $opts['target'] );
$this->setContributorsClass(
- new Contributors( Title::newFromText( $target ),
$opts->getAllValues() ) );
+ new Contributors( Title::newFromText( $opts['target']
), $opts->getAllValues() )
+ );
# What are we doing? Different execution paths for inclusion,
# direct access and raw access
--
To view, visit https://gerrit.wikimedia.org/r/403551
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2c07fca66edfb07c2d1ca58394fd07c0f9c766f
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Contributors
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
