[MediaWiki-commits] [Gerrit] mediawiki...ReadingLists[master]: Replace deprecated Maintenance::error(..., 1) calls

[Code Review]

Gergő Tisza has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403579 )

Change subject: Replace deprecated Maintenance::error(..., 1) calls
......................................................................

Replace deprecated Maintenance::error(..., 1) calls

Bug: T184612
Change-Id: I2d4f65202534fed0d351afb5a100618c3677fdf0
---
M maintenance/populateWithTestData.php
M maintenance/purge.php
2 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ReadingLists 
refs/changes/79/403579/1

diff --git a/maintenance/populateWithTestData.php 
b/maintenance/populateWithTestData.php
index 8af4f32..ca20e8d 100644
--- a/maintenance/populateWithTestData.php
+++ b/maintenance/populateWithTestData.php
@@ -36,7 +36,7 @@
                $this->addOption( 'entries', 'Entries per list (number or stats 
distribution)', false, true );
                $this->addOption( 'cleanup', 'Delete lists which look like test 
data' );
                if ( !extension_loaded( 'stats' ) ) {
-                       $this->error( 'Requires the stats PHP extension', 1 );
+                       $this->fatalError( 'Requires the stats PHP extension' );
                }
        }
 
@@ -61,7 +61,7 @@
 
                $projects = $this->dbw->selectFieldValues( 
'reading_list_project', 'rlp_id' );
                if ( !$projects ) {
-                       $this->error( 'No projects! Please set up some', 1 );
+                       $this->fatalError( 'No projects! Please set up some' );
                }
                $totalLists = $totalEntries = 0;
                stats_rand_setall( mt_rand(), mt_rand() );
@@ -176,7 +176,7 @@
                                || $this->hasOption( 'lists' )
                                || $this->hasOption( 'entries' )
                        ) {
-                               $this->error( "'cleanup' cannot be used 
together with other options", 1 );
+                               $this->fatalError( "'cleanup' cannot be used 
together with other options" );
                        }
                } else {
                        if (
@@ -184,7 +184,7 @@
                                || !$this->hasOption( 'lists' )
                                || !$this->hasOption( 'entries' )
                        ) {
-                               $this->error( "'users', 'lists' and 'entries' 
are required in non-cleanup mode", 1 );
+                               $this->fatalError( "'users', 'lists' and 
'entries' are required in non-cleanup mode" );
                        }
                }
        }
diff --git a/maintenance/purge.php b/maintenance/purge.php
index 85e571b..6ca8785 100644
--- a/maintenance/purge.php
+++ b/maintenance/purge.php
@@ -38,7 +38,7 @@
                        $before = wfTimestamp( TS_MW, $this->getOption( 
'before' ) );
                        if ( !$before || $now <= $before ) {
                                // Let's not delete all rows if the user 
entered an invalid timestamp.
-                               $this->error( 'Invalid timestamp', 1 );
+                               $this->fatalError( 'Invalid timestamp' );
                        }
                } else {
                        $before = Utils::getDeletedExpiry();

-- 
To view, visit https://gerrit.wikimedia.org/r/403579
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d4f65202534fed0d351afb5a100618c3677fdf0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ReadingLists
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits