Xqt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403618 )

Change subject: [test] Don't check for socketIO client
......................................................................

[test] Don't check for socketIO client

- rcstreams was dropped. RCStream is offline and does no longer serve
  events. It is senseless to check for socketIO_client anymore.

Bug: T170534
Change-Id: Ia494f4cb112736afe716abbda406656dfeb6f4ec
---
M tests/pagegenerators_tests.py
1 file changed, 1 insertion(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/18/403618/1

diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index d17f415..12beb9a 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -1411,17 +1411,7 @@
         super(EventStreamsPageGeneratorTestCase, cls).setUpClass()
         cls.client = 'sseclient'
         if not has_module(cls.client):
-            cls.client = 'socketIO_client'
-            try:
-                import socketIO_client
-            except ImportError:
-                raise unittest.SkipTest(
-                    'Neither sseclient nor socketIO_client is available')
-            if LooseVersion(
-                    socketIO_client.__version__) >= LooseVersion('0.6.1'):
-                raise unittest.SkipTest(
-                    'socketIO_client %s not supported by Wikimedia-Stream'
-                    % socketIO_client.__version__)
+            raise unittest.SkipTest('{0} is not available'.format(cls.client))
 
     def test_RC_pagegenerator_result(self):
         """Test RC pagegenerator."""

-- 
To view, visit https://gerrit.wikimedia.org/r/403618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia494f4cb112736afe716abbda406656dfeb6f4ec
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to