jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403638 )
Change subject: Add test for newNullRevision with bad page ID
......................................................................
Add test for newNullRevision with bad page ID
Bug: T184687
Change-Id: I893d71999f034f84bf067dedacb821a74374ea7c
---
M tests/phpunit/includes/RevisionDbTestBase.php
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/includes/RevisionDbTestBase.php
b/tests/phpunit/includes/RevisionDbTestBase.php
index 6139524..427a95e 100644
--- a/tests/phpunit/includes/RevisionDbTestBase.php
+++ b/tests/phpunit/includes/RevisionDbTestBase.php
@@ -620,6 +620,16 @@
}
/**
+ * @covers Revision::newNullRevision
+ */
+ public function testNewNullRevision_badPage() {
+ $dbw = wfGetDB( DB_MASTER );
+ $rev = Revision::newNullRevision( $dbw, -1, 'a null revision',
false );
+
+ $this->assertNull( $rev );
+ }
+
+ /**
* @covers Revision::insertOn
*/
public function testInsertOn() {
--
To view, visit https://gerrit.wikimedia.org/r/403638
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I893d71999f034f84bf067dedacb821a74374ea7c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Thiemo Kreuz (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
