Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403687 )

Change subject: Improve some parameter docs
......................................................................

Improve some parameter docs

Change-Id: I3d704c26b005e93e6a4799b13a6582e366d28567
---
M .phpcs.xml
M AddMessages.class.php
2 files changed, 4 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AddMessages 
refs/changes/87/403687/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 7959489..90e8108 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,13 +2,9 @@
 <ruleset>
        <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
-               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
-               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
-               <exclude 
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
                <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
        </rule>
        <file>.</file>
        <arg name="extensions" value="php,php5,inc" />
-       <arg name="encoding" value="utf8" />
-       <exclude-pattern>vendor</exclude-pattern>
+       <arg name="encoding" value="UTF-8" />
 </ruleset>
diff --git a/AddMessages.class.php b/AddMessages.class.php
index 7b6e68c..6f4b701 100644
--- a/AddMessages.class.php
+++ b/AddMessages.class.php
@@ -12,9 +12,9 @@
         * or add a new message
         *
         * @global array $wgAmMessages
-        * @param $cache
-        * @param $code
-        * @param array $alldata
+        * @param LocalisationCache $cache
+        * @param string $code
+        * @param array &$alldata
         * @return bool
         */
        public static function onLocalisationCacheRecache( $cache, $code, 
&$alldata ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403687
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d704c26b005e93e6a4799b13a6582e366d28567
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AddMessages
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to