Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403702 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I1a03afc58d87cce2f60e52d58fe930fecdf0aa9d
---
M .phpcs.xml
M includes/ContributorsHooks.php
2 files changed, 15 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Contributors
refs/changes/02/403702/1
diff --git a/.phpcs.xml b/.phpcs.xml
index 4e2f687..b057584 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -4,9 +4,6 @@
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude
name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
<exclude name="Squiz.Scope.MethodScope.Missing" />
</rule>
diff --git a/includes/ContributorsHooks.php b/includes/ContributorsHooks.php
index 3384bc1..9177aa6 100644
--- a/includes/ContributorsHooks.php
+++ b/includes/ContributorsHooks.php
@@ -10,7 +10,7 @@
/**
* Set up the #contributors parser function
*
- * @param Parser $parser
+ * @param Parser &$parser
*
* @return bool
*/
@@ -57,8 +57,10 @@
/**
* Prepare the toolbox link
*
- * @var $skintemplate SkinTemplate
- *
+ * @param SkinTemplate &$skintemplate
+ * @param array &$nav_urls
+ * @param int &$oldid
+ * @param int &$revid
* @return bool
*/
public static function onSkinTemplateBuildNavUrlsNav_urlsAfterPermalink(
@@ -81,6 +83,7 @@
/**
* Output the toolbox link
*
+ * @param BaseTemplate &$monobook
* @return bool
*/
public static function onSkinTemplateToolboxEnd( BaseTemplate
&$monobook ) {
@@ -118,15 +121,15 @@
*
* @param WikiPage $wikiPage
* @param User $user
- * @param $content
- * @param $summary
- * @param $isMinor
- * @param $isWatch
- * @param $section
- * @param $flags
- * @param $revision
- * @param $status
- * @param $baseRevId
+ * @param Content $content
+ * @param string $summary
+ * @param bool $isMinor
+ * @param bool $isWatch
+ * @param string $section
+ * @param int $flags
+ * @param Revision $revision
+ * @param Status $status
+ * @param int $baseRevId
*
* @throws Exception
*/
--
To view, visit https://gerrit.wikimedia.org/r/403702
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a03afc58d87cce2f60e52d58fe930fecdf0aa9d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Contributors
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
